List for cgit developers and users
 help / color / mirror / Atom feed
* add favicon to cgit
@ 2013-05-29  8:20 list
  2013-05-31  0:53 ` Jason
  0 siblings, 1 reply; 5+ messages in thread
From: list @ 2013-05-29  8:20 UTC (permalink / raw)


Hello everybody,

I was wondering why cgit does not ship a favicon by default. Could not find
any discussions about that, so I hope I do not raise a discussion that has
already been decided.

I would like to include a default favicon in cgit. The one I created includes
icons in 16x16 and 32x32 pixels. The file is optimized for size by using just
16 colors. Patch is attached.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-favicon.patch
Type: text/x-patch
Size: 2087 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20130529/9c0b29bc/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20130529/9c0b29bc/attachment.asc>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* add favicon to cgit
  2013-05-29  8:20 add favicon to cgit list
@ 2013-05-31  0:53 ` Jason
  2013-07-22  6:58   ` list
  0 siblings, 1 reply; 5+ messages in thread
From: Jason @ 2013-05-31  0:53 UTC (permalink / raw)


On Wed, May 29, 2013 at 10:20 AM, Christian Hesse <list at eworm.de> wrote:
> I was wondering why cgit does not ship a favicon by default. Could not find
> any discussions about that, so I hope I do not raise a discussion that has
> already been decided.

Looks great! Thanks Christian. Merged into master.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* add favicon to cgit
  2013-05-31  0:53 ` Jason
@ 2013-07-22  6:58   ` list
  2013-08-12 18:45     ` Jason
  0 siblings, 1 reply; 5+ messages in thread
From: list @ 2013-07-22  6:58 UTC (permalink / raw)


"Jason A. Donenfeld" <Jason at zx2c4.com> on Fri, 2013/05/31 02:53:
> On Wed, May 29, 2013 at 10:20 AM, Christian Hesse <list at eworm.de> wrote:
> > I was wondering why cgit does not ship a favicon by default. Could not
> > find any discussions about that, so I hope I do not raise a discussion
> > that has already been decided.
> 
> Looks great! Thanks Christian. Merged into master.

Do we want this to be enabled by default?
Potential patch attached.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-use-favicon-by-default.patch
Type: text/x-patch
Size: 1322 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20130722/929bf262/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20130722/929bf262/attachment.asc>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* add favicon to cgit
  2013-07-22  6:58   ` list
@ 2013-08-12 18:45     ` Jason
  2013-08-13  8:36       ` list
  0 siblings, 1 reply; 5+ messages in thread
From: Jason @ 2013-08-12 18:45 UTC (permalink / raw)


On Mon, Jul 22, 2013 at 12:58 AM, Christian Hesse <list at eworm.de> wrote:
>
>
> Do we want this to be enabled by default?
> Potential patch attached.


Yes, merged with s/iso/ico/.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20130812/c51aa9d8/attachment.html>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* add favicon to cgit
  2013-08-12 18:45     ` Jason
@ 2013-08-13  8:36       ` list
  0 siblings, 0 replies; 5+ messages in thread
From: list @ 2013-08-13  8:36 UTC (permalink / raw)


"Jason A. Donenfeld" <Jason at zx2c4.com> on Mon, 2013/08/12 12:45:
> On Mon, Jul 22, 2013 at 12:58 AM, Christian Hesse <list at eworm.de> wrote:
> > Do we want this to be enabled by default?
> > Potential patch attached.
> 
> Yes, merged with s/iso/ico/.

Uh, sorry for the typo...
And thanks a lot for merging!
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20130813/8afea0bd/attachment-0001.asc>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-08-13  8:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-29  8:20 add favicon to cgit list
2013-05-31  0:53 ` Jason
2013-07-22  6:58   ` list
2013-08-12 18:45     ` Jason
2013-08-13  8:36       ` list

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).