From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Christian Hesse <list@eworm.de>
Cc: cgit@lists.zx2c4.com, Christian Hesse <mail@eworm.de>
Subject: Re: [PATCH 2/2] global: replace hard coded hash length
Date: Thu, 22 Oct 2020 00:06:02 +0200 [thread overview]
Message-ID: <CAHmME9ov-GF3pjqy4VKHYU=Hhck08RLONJezz-=BifoN4Duy6w@mail.gmail.com> (raw)
In-Reply-To: <20201021213657.2fd34522@leda>
On Wed, Oct 21, 2020 at 9:37 PM Christian Hesse <list@eworm.de> wrote:
>
> "Jason A. Donenfeld" <Jason@zx2c4.com> on Wed, 2020/10/21 17:35:
> > Thanks! I've applied these. Next step I guess will be adding some
> > sha256 repos to the test suite.
>
> How complex do you want these tests to be?
For now, we just want to set up a sha256 repo and see that the html
correctly spits out the hashes as expected.
Later when git enables mixed object repos and dual addressiblity,
we'll want to confirm that cgit responds to both types of hashes
gracefully, and displays whichever one upstream decides is canonical
in a given situation.
next prev parent reply other threads:[~2020-10-21 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 21:58 [PATCH 1/2] global: replace references to 'sha1' with 'oid' Christian Hesse
2020-10-20 21:58 ` [PATCH 2/2] global: replace hard coded hash length Christian Hesse
2020-10-21 15:35 ` Jason A. Donenfeld
2020-10-21 15:47 ` Jason A. Donenfeld
2020-10-21 19:36 ` Christian Hesse
2020-10-21 22:06 ` Jason A. Donenfeld [this message]
2020-10-21 22:07 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9ov-GF3pjqy4VKHYU=Hhck08RLONJezz-=BifoN4Duy6w@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=cgit@lists.zx2c4.com \
--cc=list@eworm.de \
--cc=mail@eworm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).