From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 13627 invoked from network); 21 Oct 2020 22:06:16 -0000
Received: from krantz.zx2c4.com (192.95.5.69)
  by inbox.vuxu.org with ESMTPUTF8; 21 Oct 2020 22:06:16 -0000
Received: 
	by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id f2fa1f97;
	Wed, 21 Oct 2020 22:05:06 +0000 (UTC)
Return-Path: <Jason@zx2c4.com>
Received: from mail.zx2c4.com (mail.zx2c4.com [192.95.5.64])
 by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id af393c98
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <cgit@lists.zx2c4.com>;
 Wed, 21 Oct 2020 22:05:04 +0000 (UTC)
Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 579f2469
 for <cgit@lists.zx2c4.com>; Wed, 21 Oct 2020 22:05:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version
 :references:in-reply-to:from:date:message-id:subject:to:cc
 :content-type; s=mail; bh=PymmG6MOERspDqiJpCYyBWCxLow=; b=JDMPK/
 lY7vZ6OCESuFJwavNrZcEnd8VMzdqaIcduobpp/E7opA7pKliMV3tyxX98uhWpEJ
 mRTyhmZ6eGqtYQp8WZnJssg9HwaVRFTTpqTvegxaKCV2WNtLM/HnFdDjnSTc/TNC
 FT1iwUSeeJ0pk1ACGQpPPuH2SGEyyEm6hr8OEuIiFfDRf1xlsLIEkjYVTEbWSnSY
 GPxt6HXlPPhGsOY+wkmQ3SohY6LPULaySNtUNPoZoYScTP2geXfSEPvQwpex0e9X
 DDDLbKXNOhIVEnm4dS0ipQ3nVGRTJpToHg0UO8+T+FPWcnUaCKhMbelBVYtHfe5a
 /OQ+LAHXcUJ/GwLw==
Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id cd54d74b
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <cgit@lists.zx2c4.com>;
 Wed, 21 Oct 2020 22:05:50 +0000 (UTC)
Received: by mail-io1-f46.google.com with SMTP id n6so4790568ioc.12
 for <cgit@lists.zx2c4.com>; Wed, 21 Oct 2020 15:06:13 -0700 (PDT)
X-Gm-Message-State: AOAM533TG3IOnWNtzfn2l9RLBOGe75AVfauKkw/NZCeDnYZAC3PwIYx5
 d9uQ86cdpoqtDMtxeJp4+IeGUPyrGrCHcaDGFD8=
X-Google-Smtp-Source: ABdhPJzuwPkIwOK4Kfi7zrNidctwYCO1k7FxBzps56AAxgqIsuo4tO3YuTTq2rDBCkG+Ere16upNUQtBmW0wjO6tHwM=
X-Received: by 2002:a02:48:: with SMTP id 69mr2190745jaa.108.1603317972921;
 Wed, 21 Oct 2020 15:06:12 -0700 (PDT)
MIME-Version: 1.0
References: <20201020215837.205649-1-list@eworm.de>
 <20201020215837.205649-2-list@eworm.de>
 <CAHmME9qmwVo_Z_cTMv+0m6wxfGjBknxgyYi-EvUj_CPiyHbSUA@mail.gmail.com>
 <20201021213657.2fd34522@leda>
In-Reply-To: <20201021213657.2fd34522@leda>
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Thu, 22 Oct 2020 00:06:02 +0200
X-Gmail-Original-Message-ID: <CAHmME9ov-GF3pjqy4VKHYU=Hhck08RLONJezz-=BifoN4Duy6w@mail.gmail.com>
Message-ID: <CAHmME9ov-GF3pjqy4VKHYU=Hhck08RLONJezz-=BifoN4Duy6w@mail.gmail.com>
Subject: Re: [PATCH 2/2] global: replace hard coded hash length
To: Christian Hesse <list@eworm.de>
Cc: cgit@lists.zx2c4.com, Christian Hesse <mail@eworm.de>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: cgit@lists.zx2c4.com
X-Mailman-Version: 2.1.30rc1
Precedence: list
List-Id: List for cgit developers and users <cgit.lists.zx2c4.com>
List-Unsubscribe: <https://lists.zx2c4.com/mailman/options/cgit>,
 <mailto:cgit-request@lists.zx2c4.com?subject=unsubscribe>
List-Archive: <http://lists.zx2c4.com/pipermail/cgit/>
List-Post: <mailto:cgit@lists.zx2c4.com>
List-Help: <mailto:cgit-request@lists.zx2c4.com?subject=help>
List-Subscribe: <https://lists.zx2c4.com/mailman/listinfo/cgit>,
 <mailto:cgit-request@lists.zx2c4.com?subject=subscribe>
Errors-To: cgit-bounces@lists.zx2c4.com
Sender: "CGit" <cgit-bounces@lists.zx2c4.com>

On Wed, Oct 21, 2020 at 9:37 PM Christian Hesse <list@eworm.de> wrote:
>
> "Jason A. Donenfeld" <Jason@zx2c4.com> on Wed, 2020/10/21 17:35:
> > Thanks! I've applied these. Next step I guess will be adding some
> > sha256 repos to the test suite.
>
> How complex do you want these tests to be?

For now, we just want to set up a sha256 repo and see that the html
correctly spits out the hashes as expected.

Later when git enables mixed object repos and dual addressiblity,
we'll want to confirm that cgit responds to both types of hashes
gracefully, and displays whichever one upstream decides is canonical
in a given situation.