From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH] cache: flush stdio before restoring FDs
Date: Mon, 24 Apr 2017 20:55:29 +0200 [thread overview]
Message-ID: <CAHmME9pFkxUb5cYtCRtH78kpP9PD2gkuG=0EAV4QsPLiThPgJg@mail.gmail.com> (raw)
In-Reply-To: <20170424185240.GB1788@john.keeping.me.uk>
Hey John,
Wow, that was quick. Konstantin and I were just talking about this.
I'll review this and merge things asap.
Another related thing were were discussing and I was just
investigating is the inherent buffering that our cache system uses.
When it's filling a slot, everything is buffered until the end, when
the slot is printed. This doesn't work well for huge tars, which might
buffer for more than an HTTP timeout. I'm looking into calling fork()
before slot->fn() and then calling splice in the parent...
Jason
next prev parent reply other threads:[~2017-04-24 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 15:54 Bug: rawdiff output truncated on cache save mricon
2017-04-24 18:52 ` [PATCH] cache: flush stdio before restoring FDs john
2017-04-24 18:55 ` Jason [this message]
2017-04-28 16:36 ` mricon
2017-09-25 12:51 ` mricon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9pFkxUb5cYtCRtH78kpP9PD2gkuG=0EAV4QsPLiThPgJg@mail.gmail.com' \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).