List for cgit developers and users
 help / color / mirror / Atom feed
From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: Description in repo not used if not using scan-path
Date: Mon, 20 Jan 2014 21:52:23 +0100	[thread overview]
Message-ID: <CAHmME9pFs=GGvNauMreYAQ0sd8DSkxGTa8TJsnCr+icomcJVfw@mail.gmail.com> (raw)
In-Reply-To: <52DD8B79.6050109@googlemail.com>

It looks like we get description from gitweb.description, inside the git config:

        else if (!strcmp(key, "gitweb.description"))
                config_fn(repo, "desc", value);

We alternatively get it from the description file:

        if (repo->desc == cgit_default_repo_desc || !repo->desc) {
                strbuf_addstr(path, "description");
                if (!stat(path->buf, &st))
                        readfile(path->buf, &repo->desc, &size);
                strbuf_setlen(path, pathlen);
        }

It may be smart to support both of these in that function. I'll see if
I can build in description scanning. I'm not completely convinced we
want it (after all, scan-path is _not_ defined in this case), but I'll
look into it.


      reply	other threads:[~2014-01-20 20:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 22:46 pst200
2014-01-20 20:47 ` pst200
2014-01-20 20:52   ` Jason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHmME9pFs=GGvNauMreYAQ0sd8DSkxGTa8TJsnCr+icomcJVfw@mail.gmail.com' \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).