From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH 1/2] ui-shared: add homepage to tabs
Date: Mon, 22 Feb 2016 18:12:05 +0100 [thread overview]
Message-ID: <CAHmME9pOz+EF31M8h-A2X108iKeHoDe74wV4006afUsQ=tFxgg@mail.gmail.com> (raw)
In-Reply-To: <20160222170348.GC1766@serenity.lan>
Hi John,
I actually started doing that initially, with the base64 src of that exact
image, but then found that it looked bad with custom CSS, since a PNG,
unlike a font, embeds the color.
But, adding it into the CSS instead makes lots of sense. Great thinking.
Jason
On Mon, Feb 22, 2016 at 6:03 PM, John Keeping <john at keeping.me.uk> wrote:
> On Mon, Feb 22, 2016 at 04:42:12PM +0100, Jason A. Donenfeld wrote:
> > Seems like a very useful feature. I'd like some feedback on ➦
> though.
> >
> > It'd be nice to have this:
> > http://fortawesome.github.io/Font-Awesome/icon/external-link/
> > or this:
> > http://www.fileformat.info/info/unicode/char/1f517/index.htm
> >
> > But the former is overhead I won't accept and the latter isn't
> > available in all browsers.
> >
> > Thoughts?
>
> I'm not convinced by the arrow, I wonder if we'd be better off inlining
> Wikipedia's external link image [1] as base64; it's quite small and is
> licensed as GPLv2.
>
> It might be nice to move this into CSS with an "external_link" class and
> use :after to apply the image which will make per-site customization
> easier.
>
>
> [1] https://commons.wikimedia.org/wiki/File:Icon_External_Link.png
>
--
Jason A. Donenfeld
Deep Space Explorer
fr: +33 6 51 90 82 66
us: +1 513 476 1200
www.jasondonenfeld.com
www.zx2c4.com
zx2c4.com/keys/AB9942E6D4A4CFC3412620A749FC7012A5DE03AE.asc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20160222/61c9b916/attachment.html>
next prev parent reply other threads:[~2016-02-22 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 15:39 Jason
2016-02-22 15:39 ` [PATCH 2/2] cmd: redirect empty about/ to homepage or summary Jason
2016-02-22 15:42 ` [PATCH 1/2] ui-shared: add homepage to tabs Jason
2016-02-22 17:03 ` john
2016-02-22 17:12 ` Jason [this message]
2016-02-22 17:29 ` Jason
2016-02-23 6:49 ` peter
2016-02-23 14:26 ` Jason
2016-02-23 14:32 ` john
2016-02-23 14:36 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9pOz+EF31M8h-A2X108iKeHoDe74wV4006afUsQ=tFxgg@mail.gmail.com' \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).