From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason at zx2c4.com (Jason A. Donenfeld) Date: Mon, 22 Feb 2016 18:12:05 +0100 Subject: [PATCH 1/2] ui-shared: add homepage to tabs In-Reply-To: <20160222170348.GC1766@serenity.lan> References: <1456155590-9342-1-git-send-email-Jason@zx2c4.com> <20160222170348.GC1766@serenity.lan> Message-ID: Hi John, I actually started doing that initially, with the base64 src of that exact image, but then found that it looked bad with custom CSS, since a PNG, unlike a font, embeds the color. But, adding it into the CSS instead makes lots of sense. Great thinking. Jason On Mon, Feb 22, 2016 at 6:03 PM, John Keeping wrote: > On Mon, Feb 22, 2016 at 04:42:12PM +0100, Jason A. Donenfeld wrote: > > Seems like a very useful feature. I'd like some feedback on ➦ > though. > > > > It'd be nice to have this: > > http://fortawesome.github.io/Font-Awesome/icon/external-link/ > > or this: > > http://www.fileformat.info/info/unicode/char/1f517/index.htm > > > > But the former is overhead I won't accept and the latter isn't > > available in all browsers. > > > > Thoughts? > > I'm not convinced by the arrow, I wonder if we'd be better off inlining > Wikipedia's external link image [1] as base64; it's quite small and is > licensed as GPLv2. > > It might be nice to move this into CSS with an "external_link" class and > use :after to apply the image which will make per-site customization > easier. > > > [1] https://commons.wikimedia.org/wiki/File:Icon_External_Link.png > -- Jason A. Donenfeld Deep Space Explorer fr: +33 6 51 90 82 66 us: +1 513 476 1200 www.jasondonenfeld.com www.zx2c4.com zx2c4.com/keys/AB9942E6D4A4CFC3412620A749FC7012A5DE03AE.asc -------------- next part -------------- An HTML attachment was scrubbed... URL: