From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH] Do not load user or system gitconfig and gitattributes
Date: Mon, 8 Apr 2013 21:50:04 +0200 [thread overview]
Message-ID: <CAHmME9pV3g_iUrPWpdbkKpQhXAvoM-hT-HWuheJzqC+SnktywA@mail.gmail.com> (raw)
In-Reply-To: <20130408194437.GC2222@serenity.lan>
On Mon, Apr 8, 2013 at 9:44 PM, John Keeping <john at keeping.me.uk> wrote:
>
> Looks sensible, but I don't think it's quite guaranteed to do what you
> want, since Git can call git_config at any time and it re-reads the
> files whenever it does. We may not be doing anything that causes it to
> be reparsed now, but will we notice if that changes?
Test case time!
>
> Is there any reason not to leave $HOME and $XDG_CONFIG_HOME unset?
Yes. Various parts of cgit shell out to scripts -- filters etc -- and
these scripts may very much benefit from having a $HOME.
> I don't know how closely you think CGit should stick to that style
> though.
Actually, to date, cgit has been using
/* Comments that
* are like this.
*/
as well as
/*
* Comments that
* are like this.
*/
as well as
// comments that
// are like this.
the last of which is pretty gross.
At some point I'll have to clean up and normalize all of these.
prev parent reply other threads:[~2013-04-08 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 19:33 Jason
2013-04-08 19:37 ` mailings
2013-04-08 19:42 ` Jason
2013-04-08 19:44 ` john
2013-04-08 19:50 ` Jason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9pV3g_iUrPWpdbkKpQhXAvoM-hT-HWuheJzqC+SnktywA@mail.gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).