From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Mon, 8 Apr 2013 21:50:04 +0200
Subject: [PATCH] Do not load user or system gitconfig and gitattributes
In-Reply-To: <20130408194437.GC2222@serenity.lan>
References: <1365449611-21670-1-git-send-email-Jason@zx2c4.com>
 <20130408194437.GC2222@serenity.lan>
Message-ID: <CAHmME9pV3g_iUrPWpdbkKpQhXAvoM-hT-HWuheJzqC+SnktywA@mail.gmail.com>

On Mon, Apr 8, 2013 at 9:44 PM, John Keeping <john at keeping.me.uk> wrote:
>
> Looks sensible, but I don't think it's quite guaranteed to do what you
> want, since Git can call git_config at any time and it re-reads the
> files whenever it does.  We may not be doing anything that causes it to
> be reparsed now, but will we notice if that changes?

Test case time!

>
> Is there any reason not to leave $HOME and $XDG_CONFIG_HOME unset?

Yes. Various parts of cgit shell out to scripts -- filters etc -- and
these scripts may very much benefit from having a $HOME.



> I don't know how closely you think CGit should stick to that style
> though.

Actually, to date, cgit has been using

/* Comments that
 *  are like this.
 */

as well as

/*
  * Comments that
 *  are like this.
 */

as well as

// comments that
// are like this.

the last of which is pretty gross.

At some point I'll have to clean up and normalize all of these.