[PATCH] ui-commit: use Git raw note format

[PATCH] ui-commit: use Git raw note format

[aklhfex]

Currently a commit note is shown as:

Notes

  Notes:
      <note text>

Change to:

Notes
  <note text>

Signed-off-by: Chris Mayo <aklhfex at gmail.com>
---
 ui-commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui-commit.c b/ui-commit.c
index 9a47b54..52b4c2a 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -39,7 +39,7 @@ void cgit_print_commit(char *hex, const char *prefix)
 	}
 	info = cgit_parse_commit(commit);
 
-	format_display_notes(&oid, &notes, PAGE_ENCODING, 0);
+	format_display_notes(&oid, &notes, PAGE_ENCODING, 1);
 
 	load_ref_decorations(NULL, DECORATE_FULL_REFS);
 
-- 
2.21.0

Re: [PATCH] ui-commit: use Git raw note format

[Alyssa Ross]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Chris Mayo <aklhfex@gmail.com> writes:

> Currently a commit note is shown as:
>
> Notes
>
>   Notes:
>       <note text>
>
> Change to:
>
> Notes
>   <note text>
>
> Signed-off-by: Chris Mayo <aklhfex@gmail.com>
>
> ---
>  ui-commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Just wanted to say I've been using this patch for a while and it works
great for me.

IDK if a review from a rando is worth anything on this list, but just in
case:

Reviewed-by: Alyssa Ross <hi@alyssa.is>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH] ui-commit: use Git raw note format

[Jason A. Donenfeld]

Wondering what the purpose of this is? Why would you prefer this
format over the other one?

Re: [PATCH] ui-commit: use Git raw note format

[Alyssa Ross]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

On Mon, Dec 19, 2022 at 03:28:12PM +0100, Jason A. Donenfeld wrote:
> Wondering what the purpose of this is? Why would you prefer this
> format over the other one?

The current format says "Notes" twice in a row, as exemplified in the
patch description.  It's redundant.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]