From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger
Date: Wed, 8 Jan 2014 16:12:38 +0100 [thread overview]
Message-ID: <CAHmME9pbkGfZbvCVB4rmiqMMDS0imF40xA56V7vvjZZM6=xb5w@mail.gmail.com> (raw)
In-Reply-To: <1389192811-31573-1-git-send-email-mail@eworm.de>
I like this. But I could imagine a bit of backlash against it -- it's
a particular web service owned by a private corporation (Automattic),
and some detractors might argue that an open project like this has no
interest in this kind of proprietary service integration. Are there
any such detractors on this list? If so, we can fill this thread with
some sort of discussion. Otherwise, pending the nitpicks below, I'll
merge it.
On Wed, Jan 8, 2014 at 3:53 PM, Christian Hesse <mail at eworm.de> wrote:
> +
> +char * cgit_get_gravatar(const char *email) {
> + unsigned char digest[MD5_DIGEST_LENGTH];
char *cgit_get_gravatar(const char *email)
{
> + /* The URL includes %s, which is replaced later on. So we do not need
> + * extra space for termination. */
> + gravatar = malloc(strlen(GRAVATAR_URL) + MD5_DIGEST_LENGTH * 2);
This is clever, but potentially error prone.
next prev parent reply other threads:[~2014-01-08 15:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 14:34 Welcome on board Lukas Fleischer Jason
2014-01-08 14:53 ` [RESEND PATCH 1/1] enable cgit to show gravatar for author, committer and tagger mail
2014-01-08 15:12 ` Jason [this message]
2014-01-08 15:23 ` [PATCH " mail
2014-01-08 15:56 ` Jason
2014-01-09 8:52 ` mail
2014-01-09 15:13 ` Jason
2014-01-08 16:00 ` Jason
2014-01-09 9:13 ` mail
2014-01-08 15:36 ` [RESEND PATCH " mathstuf
2014-01-08 17:15 ` normalperson
2014-01-08 17:29 ` Jason
2014-01-08 18:35 ` stefan
2014-01-09 9:18 ` list
2014-01-09 15:19 ` Jason
2014-01-13 14:18 ` list
2014-01-13 14:24 ` Jason
2014-01-14 17:22 ` list
2014-01-14 17:23 ` Jason
2014-01-14 17:35 ` list
2014-01-14 17:45 `
2014-01-14 17:51 ` Jason
2014-01-14 17:58 ` list
2014-01-14 18:00 ` Jason
2014-01-09 15:21 ` RFE: author/committer/tagger links (enable cgit to show gravatar for author, committer and tagger) mricon
2014-01-09 17:50 ` Jason
2014-01-09 18:07 ` john
2014-01-09 18:59 ` Jason
2014-01-09 19:23 ` john
2014-01-09 19:34 ` cgit
2014-01-09 19:38 ` Welcome on board Lukas Fleischer info
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9pbkGfZbvCVB4rmiqMMDS0imF40xA56V7vvjZZM6=xb5w@mail.gmail.com' \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).