From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 11751 invoked from network); 11 Jan 2023 20:56:49 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 11 Jan 2023 20:56:49 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 080eeece; Wed, 11 Jan 2023 20:56:48 +0000 (UTC) Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 03c5b203 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Wed, 11 Jan 2023 20:56:45 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7DAA961DC0 for ; Wed, 11 Jan 2023 20:56:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 812C9C433EF for ; Wed, 11 Jan 2023 20:56:43 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="V48jiqKF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1673470602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jf7G0R8Vz1tLwte156xUJJKKg9YJ94c8mF5NXkAEKcg=; b=V48jiqKFZopdpOPPZVivySP64EnoDuLeKZTz6343EiXZW59Lh9v5Crm6BuAUmyd7667UW/ 3esIFfr9qOSNXsurWRdQp6jEYWxj3KjDCmnqvzLiSan6lkRkYtbXBCBJbyjwOPb9kav/4o 6iGBYlPzJi4HI8IkslfDd2NLl+p8Aa0= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 9df663a5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Wed, 11 Jan 2023 20:56:41 +0000 (UTC) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-4a2f8ad29d5so211513017b3.8 for ; Wed, 11 Jan 2023 12:56:41 -0800 (PST) X-Gm-Message-State: AFqh2kqu7tdvnIRoNq2l0WQelHanMM+l5kwTtjMLNLFB6Y65rZz2DPbH Qk2zuYk7MhTqCA+SuczpTreLaMgUYnB4RsZAB2U= X-Google-Smtp-Source: AMrXdXtGTlzISTsrfgQL+RD59RH8aUR4qlOfwJI/JUQoGCB/a2ZzxpjZJJgq8Xn/gUte6prCsICJhICwhWmUb60vdig= X-Received: by 2002:a81:494a:0:b0:3dd:bcc2:e359 with SMTP id w71-20020a81494a000000b003ddbcc2e359mr2355932ywa.341.1673470601278; Wed, 11 Jan 2023 12:56:41 -0800 (PST) MIME-Version: 1.0 References: <20230101214103.1E52F19A2@badger.kodafritt.se> <20230105225343.0264A262C@badger.kodafritt.se> In-Reply-To: From: "Jason A. Donenfeld" Date: Wed, 11 Jan 2023 21:56:30 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RESEND v2] css: Support for dark mode To: samuel@kodafritt.se Cc: cgit@lists.zx2c4.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" It looks like the issue is that the string class for the light theme is: .highlight .s { color: #dd2200; background-color: #fff0f0; } But for the dark theme it's: @media (prefers-color-scheme: dark) .highlight .s { color: #e6db74; } And so it winds up using the dark color, but with the light background, because the dark theme doesn't specify a background.