From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Sun, 7 Apr 2013 14:37:09 +0200
Subject: [PATCH 19/19] ui-shared.c: use struct strbuf instead of fmt()
In-Reply-To: <4015edb895155d4e092576383cfd790e02d4e197.1365326321.git.john@keeping.me.uk>
References: <cover.1365326321.git.john@keeping.me.uk>
 <4015edb895155d4e092576383cfd790e02d4e197.1365326321.git.john@keeping.me.uk>
Message-ID: <CAHmME9pqsNYk-CgU=bsMktALPUjyQpgB-ZQ-PO+qjZ5ffHvQfw@mail.gmail.com>

On Sun, Apr 7, 2013 at 11:30 AM, John Keeping <john at keeping.me.uk> wrote:
>  const char *cgit_hosturl()
>  {
> +       struct strbuf sb = STRBUF_INIT;
>         if (ctx.env.http_host)
>                 return ctx.env.http_host;
>         if (!ctx.env.server_name)
>                 return NULL;
>         if (!ctx.env.server_port || atoi(ctx.env.server_port) == 80)
>                 return ctx.env.server_name;
> -       return xstrdup(fmt("%s:%s", ctx.env.server_name, ctx.env.server_port));
> +       strbuf_addf(&sb, "%s:%s", ctx.env.server_name, ctx.env.server_port);
> +       return strbuf_detach(&sb, NULL);
>  }

Constness issues, since we're going to want to perhaps deallocate this
at some point?