List for cgit developers and users
 help / color / mirror / Atom feed
From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: Missing dependency
Date: Fri, 17 Jan 2014 23:36:07 +0100	[thread overview]
Message-ID: <CAHmME9pwqBJ+RDP7axsPjWaTt2rhm=jkswf+DiKH_3EMq2X+vg@mail.gmail.com> (raw)
In-Reply-To: <CAG=jP7g6in5H255i7rncPRmrJ+_uLDu5M40e38QOmq1TKgoQqA@mail.gmail.com>

On Fri, Jan 17, 2014 at 8:08 PM, F?lix C. Morency
<felix.morency at gmail.com> wrote:
> You should add pkg-config to the list of dependencies in the README. It is
> required if you want to build with Lua support. Also, it might be a good
> idea to check for pkg-config presence in the Makefile.

Thanks for the report; this is a good idea.

Do you have any ideas on a fallback, for when pkg-config isn't
available? I know for LUA_IMPLEMENTATION=VANILLA, we can probably just
add a -llua to LIBS, but it's not as straight forward for
LUA_IMPLEMENTATION=JIT. Any feedback would be most appreciated.

Jason


  reply	other threads:[~2014-01-17 22:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-17 19:08 
2014-01-17 22:36 ` Jason [this message]
2014-01-20 15:07   ` 

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHmME9pwqBJ+RDP7axsPjWaTt2rhm=jkswf+DiKH_3EMq2X+vg@mail.gmail.com' \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).