From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Sat, 16 Jun 2018 18:15:17 +0200
Subject: [PATCH 1/1] RFC: git: update to v2.18.0-rc2
In-Reply-To: <20180616161409.GB1922@john.keeping.me.uk>
References: <20180613225225.9945-1-list@eworm.de>
 <20180616161409.GB1922@john.keeping.me.uk>
Message-ID: <CAHmME9pynGt_X=VecBySbohV9MU4n6gZsHNEbgyEK+FR3UQHVw@mail.gmail.com>

On Sat, Jun 16, 2018 at 6:14 PM John Keeping <john at keeping.me.uk> wrote:
> But we still have a few mentions of sha1 in our code.  Most of this is
> sha1 and sha2 in struct cgit_query, but these aren't actually hashes
> most of the time, they can be any object reference that Git understands,
> so I think we should rename them to ref1 and ref2 (along with has_sha1
> -> has_ref).  What do you think?

Yes, please. This is some excellent progress.