From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 25274 invoked from network); 29 Dec 2020 11:37:58 -0000
Received: from krantz.zx2c4.com (192.95.5.69)
  by inbox.vuxu.org with ESMTPUTF8; 29 Dec 2020 11:37:58 -0000
Received: 
	by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 604b178f;
	Tue, 29 Dec 2020 11:27:52 +0000 (UTC)
Return-Path: <Jason@zx2c4.com>
Received: from mail.zx2c4.com (mail.zx2c4.com [192.95.5.64])
 by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 2c0a2362
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <cgit@lists.zx2c4.com>;
 Tue, 29 Dec 2020 11:27:50 +0000 (UTC)
Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 6e4afd99
 for <cgit@lists.zx2c4.com>; Tue, 29 Dec 2020 11:28:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version
 :references:in-reply-to:from:date:message-id:subject:to:cc
 :content-type; s=mail; bh=kxT9LQnuHE7FojstSK52Nl/zaX8=; b=PZKlQZ
 sislTqOnw3lorVIIbN9YjPd7AVmGeIuWUDvDdZR3gvxC2RwdMdOp3G7AgdAp7X4z
 R3Tm1exGewpNdidBFgdC99+bQbyLflx7PXW4mDVGdsTzy3Piydk3UbRsaKlkBE5w
 ePJSqKN77GXN6HnTSmFr1cVxY+IbFXBl7VnKfRMLmUN5zEZ5YlPP4avzV0pJ6oYQ
 EE6rHWnr+GTevU2YsRK50W3vVRqDqbaSAn0XS81scyFAYMpi69AJXLENkBalqn06
 3vc+AxczXiVVCcCKRQAq6c2lGSuutsSNuHJvrBfZhF2/8SqeGVCSWET9Jqr/jvqg
 i+CnSp6ZcV7kG+iw==
Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id e2a83f2a
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <cgit@lists.zx2c4.com>;
 Tue, 29 Dec 2020 11:28:36 +0000 (UTC)
Received: by mail-yb1-f173.google.com with SMTP id j17so12077913ybt.9
 for <cgit@lists.zx2c4.com>; Tue, 29 Dec 2020 03:37:54 -0800 (PST)
X-Gm-Message-State: AOAM530B0GoH2d62S7ybaWA4dub98dzwEyAtFvj09+x0lR1eWEV12C/S
 sLROof2kF0lObK0X1HCuD5KFfCSi3pXD4FRrxZI=
X-Google-Smtp-Source: ABdhPJwll7KtI0gsjSU12QKnswQ7fmaJvKw2VKsoudi8zuLi8RygZacB2quS9CYArqto687H+7VDXdCLiOpu8+SuzPo=
X-Received: by 2002:a25:4744:: with SMTP id u65mr74573546yba.239.1609241873936; 
 Tue, 29 Dec 2020 03:37:53 -0800 (PST)
MIME-Version: 1.0
References: <20201228133550.67945-1-uqs@FreeBSD.org>
In-Reply-To: <20201228133550.67945-1-uqs@FreeBSD.org>
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Tue, 29 Dec 2020 12:37:43 +0100
X-Gmail-Original-Message-ID: <CAHmME9q339vMyYsPQW1uRTYMiY_MRrEqcy-8V4df5YaqhaiFig@mail.gmail.com>
Message-ID: <CAHmME9q339vMyYsPQW1uRTYMiY_MRrEqcy-8V4df5YaqhaiFig@mail.gmail.com>
Subject: Re: [PATCH] Handle tags outside of refs/tags gracefully.
To: uqs@freebsd.org
Cc: cgit@lists.zx2c4.com
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: cgit@lists.zx2c4.com
X-Mailman-Version: 2.1.30rc1
Precedence: list
List-Id: List for cgit developers and users <cgit.lists.zx2c4.com>
List-Unsubscribe: <https://lists.zx2c4.com/mailman/options/cgit>,
 <mailto:cgit-request@lists.zx2c4.com?subject=unsubscribe>
List-Archive: <http://lists.zx2c4.com/pipermail/cgit/>
List-Post: <mailto:cgit@lists.zx2c4.com>
List-Help: <mailto:cgit-request@lists.zx2c4.com?subject=help>
List-Subscribe: <https://lists.zx2c4.com/mailman/listinfo/cgit>,
 <mailto:cgit-request@lists.zx2c4.com?subject=subscribe>
Errors-To: cgit-bounces@lists.zx2c4.com
Sender: "CGit" <cgit-bounces@lists.zx2c4.com>

This is for the tag UI, though. Aren't tags supposed to live in
refs/tags/ by definition?

Special casing "refs/" also winds up breaking repositories that
accidentally push tags literally named 'refs/tags/something'. I've
seen this happen quite a few times in the real world.