* RFE: Add <span> around tag decorations
@ 2013-05-13 14:27 mricon
2013-05-18 15:06 ` Jason
0 siblings, 1 reply; 2+ messages in thread
From: mricon @ 2013-05-13 14:27 UTC (permalink / raw)
Hi, all:
Android projects have *silly* amounts of tags, e.g. take a look at this
page:
https://www.codeaurora.org/cgit/external/gigabyte/platform/hardware/ti/omap3/
You will notice that it's pretty broken because of the horizontal
scroll. We can work around this with CSS, but only when decorations are
inside its own element, such as <span> (believe, me, I tried). Here's
how it looks in a patched version of cgit 0.9.1 that implements the
<span>, plus some css hacking to make the tag display not suck (hover
over commit to show the tags):
https://www-stg.codeaurora.org/cgit/external/gigabyte/platform/hardware/ti/omap3/
The change to make is in show_commit_decorations. My C is not good at
all, so I'm sending this in python/C pseudocode (heh) instead of a patch ;).
if not len(deco):
return
html("<span class='deco-span'>");
while (deco) {
...
}
html ("</span>");
As it's just an additional span, it shouldn't break any existing CSS
configurations, but will allow projects that abuse^W use extensive
tagging to display the pages without completely breaking things.
Best,
--
Konstantin Ryabitsev
Senior Systems Administrator
Linux Foundation Collab Projects
Montr?al, Qu?bec
^ permalink raw reply [flat|nested] 2+ messages in thread
* RFE: Add <span> around tag decorations
2013-05-13 14:27 RFE: Add <span> around tag decorations mricon
@ 2013-05-18 15:06 ` Jason
0 siblings, 0 replies; 2+ messages in thread
From: Jason @ 2013-05-18 15:06 UTC (permalink / raw)
Seems reasonable. I'll merge John's commit.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-18 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-13 14:27 RFE: Add <span> around tag decorations mricon
2013-05-18 15:06 ` Jason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).