From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9776 invoked from network); 2 Jan 2023 00:52:41 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 2 Jan 2023 00:52:41 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 0fa0486f; Mon, 2 Jan 2023 00:52:13 +0000 (UTC) Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id ec25c928 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Mon, 2 Jan 2023 00:52:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4C8760E73 for ; Mon, 2 Jan 2023 00:52:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DABC9C433EF for ; Mon, 2 Jan 2023 00:52:09 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="DDZuzy89" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1672620727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EhbzEqdsgatrOr5ZkBIPGa41jWhuJxfNbo7A5HwygG0=; b=DDZuzy896P8sCfR3ZHcEz8435mIRon3AUYUARUd8XzQruijA61bnqjCHs6TKJ8MzlAhduW 4lYercLKR4hwdm6d/qL/jcWdayc/51gRJGURpWH2wTr/rbhxALSYOM6xETjdNM0O4kPrs2 RkvgWwijuJmCLdMqIxMx88Ht3S5N1Yg= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id d93a6abd (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Mon, 2 Jan 2023 00:52:06 +0000 (UTC) Received: by mail-yb1-f175.google.com with SMTP id g4so28937800ybg.7 for ; Sun, 01 Jan 2023 16:52:06 -0800 (PST) X-Gm-Message-State: AFqh2koOidG6WTiCggzLa/+pW0ThBKtsbYkccoLv98Gb6KsPyygJjN9o idvFwG3iV+Nk89i4Fk0UX3sXYg7Lbm88HG8P0ds= X-Google-Smtp-Source: AMrXdXv6pQA21eBtuLQ0b+ZbPGFkQ8Nkqybk29gGhPBFEV4b1cJ7hnqn3Q3MkKZKmb3Oo2o2jlaN1zOa3P3mhy6Q1AQ= X-Received: by 2002:a25:c89:0:b0:703:8a9c:fd with SMTP id 131-20020a250c89000000b007038a9c00fdmr4132369ybm.231.1672620726278; Sun, 01 Jan 2023 16:52:06 -0800 (PST) MIME-Version: 1.0 References: <20230101214103.1E52F19A2@badger.kodafritt.se> In-Reply-To: <20230101214103.1E52F19A2@badger.kodafritt.se> From: "Jason A. Donenfeld" Date: Mon, 2 Jan 2023 01:51:55 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] css: Optional support for dark mode To: samuel@kodafritt.se Cc: cgit@lists.zx2c4.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" Hi Samuel, On Sun, Jan 1, 2023 at 10:41 PM Samuel Lid=C3=A9n Borell wrote: > > Modern browsers have a "dark mode" preference, which enables alternate > CSS rules on web sites that support this. > > This patch adds an optional dark color scheme, that can be copied into > cgit.css. The color scheme is then auto-detected via a @media query. > > Note that filters that use color (such as source highlighters), and > logotypes, may need to be updated to work with a black background. So > this goes into a separate file, that can be copied into cgit.css for > those who want to enable support for dark mode. Rather, let's just include this in the default cgit.css file, people will just fix whatever source filters being used. That means the ones in-tree should be updated first. Specifically, syntax-highlighting.py and maybe even syntax-highlighting.sh should be updated. Jason