From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH v5 1/1] ui-shared: allow to split the repository link
Date: Wed, 23 Nov 2016 05:15:54 +0100 [thread overview]
Message-ID: <CAHmME9q_4uSaaXhrko8ZUJdge1CuO4_uukpUJwmPfAX0sTLniw@mail.gmail.com> (raw)
In-Reply-To: <1463067852-22123-1-git-send-email-petr.vorel@gmail.com>
Hi Petr,
Sorry this has taken so long to review properly. Comments inline below:
On Thu, May 12, 2016 at 5:44 PM, Petr Vorel <petr.vorel at gmail.com> wrote:
> This behaviour is not implemented for repositories which have
> "repo.name" set different than "repo.url".
That's annoying. Why? Is there a way to make the behavior consistant?
Is gitweb inconsistent like this too?
>
> This feature is controlled by a new config variable:
> "split-summary-repo-link" (disabled by default).
I realize that John asked for a config variable in v3. But I do wonder
if this really is so necessary. In what case would somebody _not_ want
this behavior?
> +split-summary-repo-link::
> + Flag which, when set to "1", will make cgit split the repository link in
> + the top of repository "summary" view. This emulates the same behaviour as
> + it's in gitweb. This behaviour is not implemented for repositories which
> + have "repo.name" set different than "repo.url". Default value: "0".
Grammatical errors. No need to mention gitweb.
next prev parent reply other threads:[~2016-11-23 4:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 15:44 petr.vorel
2016-06-06 11:20 ` petr.vorel
2016-08-29 23:11 ` petr.vorel
2016-08-30 2:55 ` Jason
2016-11-23 4:15 ` Jason [this message]
2016-11-24 17:32 ` petr.vorel
2016-11-24 17:42 ` Jason
2016-11-24 19:14 ` john
2016-11-27 6:51 ` petr.vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9q_4uSaaXhrko8ZUJdge1CuO4_uukpUJwmPfAX0sTLniw@mail.gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).