From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH v2] filters: Improved syntax-highlighting.py
Date: Mon, 13 Jan 2014 15:21:32 +0100 [thread overview]
Message-ID: <CAHmME9r+990t5Ev11k-HNye+vt=1cYh-vZ=SmpuGnT_f_KGLWg@mail.gmail.com> (raw)
In-Reply-To: <1389610943-20120-1-git-send-email-stefan@sevenbyte.org>
Thanks for all your hard work on this. Sorry for the extended back and
forth. More comments, alas alas, below.
On Mon, Jan 13, 2014 at 12:02 PM, Stefan Tatschner <stefan at sevenbyte.org> wrote:
> - Using inline CSS instead of this sys.stdout.print() hack.
Please don't do this. Inline CSS makes for much bigger files, and
there's nothing in the HTML5 spec that forbids us from putting <style>
tags there in the first place.
> - Using trac theme for pygments (it is very clean and not intrusive like the
> default or pastie theme).
This is probably best as a separate commit, since some folks might complain.
> - I had to fix cgit.css according to a alignment issue with the line-numbers
> table.
This is this issue, right?
https://code.google.com/p/chromium/issues/detail?id=141945
http://data.zx2c4.com/italics-broken.png
http://data.zx2c4.com/italics-broken.html
Why does changing the line-height to 125% fix it exactly?
next prev parent reply other threads:[~2014-01-13 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 11:02 stefan
2014-01-13 14:21 ` Jason [this message]
[not found] ` <52D3FC8C.7040809@sevenbyte.org>
2014-01-13 14:49 ` stefan
[not found] ` <CAHmME9quebs1U7-QxZQ7eZNS=j=dMRzr0zsqfdO=V=EM3rqPtw@mail.gmail.com>
2014-01-13 14:50 ` Jason
2014-01-13 14:53 ` stefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9r+990t5Ev11k-HNye+vt=1cYh-vZ=SmpuGnT_f_KGLWg@mail.gmail.com' \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).