* LF - patch status
@ 2013-03-05 0:46 Jason
2013-03-05 0:47 ` Jason
0 siblings, 1 reply; 2+ messages in thread
From: Jason @ 2013-03-05 0:46 UTC (permalink / raw)
On Mon, Mar 4, 2013 at 10:00 AM, Lukas Fleischer <cgit at cryptocrack.de> wrote:
> Hi Jason,
>
> I just noticed you rebased the master branch of the official repository.
Indeed, a goof-up of sorts. The wip branch will be making a return.
>
> The other thing I wanted to ask for is feedback on the patch sets I
> submitted (marking stuff static and fixing memory leaks). I have some
> more ideas but I'd like to wait with implementing until I get feedback
> on what I already submitted to make sure I won't have to rewrite loads
> of commits.
I checked over each one of these carefully before merging -- these are
excellent. Passing pointers to the context pointer argument of the git
functions is indeed the way we should be doing it. We need global
objects for things like the current request and current configuration,
but if we can reduce globals in general, it will make things easier to
debug, and should also aid in the eventual support for fastcgi.
^ permalink raw reply [flat|nested] 2+ messages in thread
* LF - patch status
2013-03-05 0:46 LF - patch status Jason
@ 2013-03-05 0:47 ` Jason
0 siblings, 0 replies; 2+ messages in thread
From: Jason @ 2013-03-05 0:47 UTC (permalink / raw)
On Mon, Mar 4, 2013 at 7:46 PM, Jason A. Donenfeld <Jason at zx2c4.com> wrote:
>> submitted (marking stuff static and fixing memory leaks)
Ahhh, misread this. I'm about to start reviewing those now. I'll get
back to you soon!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-05 0:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-05 0:46 LF - patch status Jason
2013-03-05 0:47 ` Jason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).