List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH] doc: use consistent id's when generating html files
@ 2018-02-20 22:10 tmz
  2018-02-20 22:12 ` Jason
  0 siblings, 1 reply; 5+ messages in thread
From: tmz @ 2018-02-20 22:10 UTC (permalink / raw)


The html documentation is generated using a2x which calls docbook tools
to do the work.  The generate.consistent.ids parameter ensures that when
the docbook stylesheet assigns an id value to an output element it is
consistent as long as the document structure has not changed.

Having consistent html files reduces frivolous changes between builds.
Distributions can more easily deploy multiple architecture builds and
compare changes between package versions.  End-users avoid needless
changes in files deployed or backed up.

The generate.consistent.ids parameter was added in docbook-xsl-1.77.0.
Older versions gracefully ignore the parameter, so we can pass the
parameter unconditionally.  Most distributions contain docbook-xsl newer
than 1.77.0.  This includes Fedora, Debian, Ubuntu, and RHEL/CentOS 7.
RHEL/CentOS 6 and Debian Wheezy (old stable) ship with an older version,
unsurprisingly.
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 8321ecc..687069f 100644
--- a/Makefile
+++ b/Makefile
@@ -134,7 +134,7 @@ doc-pdf: $(DOC_PDF)
 	a2x -f manpage $<
 
 $(DOC_HTML): %.html : %.txt
-	a2x -f xhtml --stylesheet=cgit-doc.css $<
+	a2x -f xhtml --stylesheet=cgit-doc.css --xsltproc-opts="--param generate.consistent.ids 1" $<
 
 $(DOC_PDF): %.pdf : %.txt
 	a2x -f pdf cgitrc.5.txt
-- 
2.16.2



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] doc: use consistent id's when generating html files
  2018-02-20 22:10 [PATCH] doc: use consistent id's when generating html files tmz
@ 2018-02-20 22:12 ` Jason
  2018-02-20 22:28   ` tmz
  0 siblings, 1 reply; 5+ messages in thread
From: Jason @ 2018-02-20 22:12 UTC (permalink / raw)


Seems reasonable to me. Can you resubmit with your `Signed-off-by:`?

Jason


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] doc: use consistent id's when generating html files
  2018-02-20 22:12 ` Jason
@ 2018-02-20 22:28   ` tmz
  2018-02-21  1:36     ` tmz
  0 siblings, 1 reply; 5+ messages in thread
From: tmz @ 2018-02-20 22:28 UTC (permalink / raw)


The html documentation is generated using a2x which calls docbook tools
to do the work.  The generate.consistent.ids parameter ensures that when
the docbook stylesheet assigns an id value to an output element it is
consistent as long as the document structure has not changed.

Having consistent html files reduces frivolous changes between builds.
Distributions can more easily deploy multiple architecture builds and
compare changes between package versions.  End-users avoid needless
changes in files deployed or backed up.

The generate.consistent.ids parameter was added in docbook-xsl-1.77.0.
Older versions gracefully ignore the parameter, so we can pass the
parameter unconditionally.  Most distributions contain docbook-xsl newer
than 1.77.0.  This includes Fedora, Debian, Ubuntu, and RHEL/CentOS 7.
RHEL/CentOS 6 and Debian Wheezy (old stable) ship with an older version,
unsurprisingly.
---
Jason A. Donenfeld wrote:
> Seems reasonable to me. Can you resubmit with your `Signed-off-by:`?

D'oh!

I meant to check that I had the sign-off and managed to get
sidetracked before sending.  Signed-off-by: Scatterbrain. ;)

Thanks!

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 8321ecc..687069f 100644
--- a/Makefile
+++ b/Makefile
@@ -134,7 +134,7 @@ doc-pdf: $(DOC_PDF)
 	a2x -f manpage $<
 
 $(DOC_HTML): %.html : %.txt
-	a2x -f xhtml --stylesheet=cgit-doc.css $<
+	a2x -f xhtml --stylesheet=cgit-doc.css --xsltproc-opts="--param generate.consistent.ids 1" $<
 
 $(DOC_PDF): %.pdf : %.txt
 	a2x -f pdf cgitrc.5.txt
-- 
2.16.2

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Philosophy, n. A route of many roads leading from nowhere to nothing.
    -- Ambrose Bierce, "The Devil's Dictionary"



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] doc: use consistent id's when generating html files
  2018-02-20 22:28   ` tmz
@ 2018-02-21  1:36     ` tmz
  2018-02-21  2:13       ` Jason
  0 siblings, 1 reply; 5+ messages in thread
From: tmz @ 2018-02-21  1:36 UTC (permalink / raw)


The html documentation is generated using a2x which calls docbook tools
to do the work.  The generate.consistent.ids parameter ensures that when
the docbook stylesheet assigns an id value to an output element it is
consistent as long as the document structure has not changed.

Having consistent html files reduces frivolous changes between builds.
Distributions can more easily deploy multiple architecture builds and
compare changes between package versions.  End-users avoid needless
changes in files deployed or backed up.

The generate.consistent.ids parameter was added in docbook-xsl-1.77.0.
Older versions gracefully ignore the parameter, so we can pass the
parameter unconditionally.  Most distributions contain docbook-xsl newer
than 1.77.0.  This includes Fedora, Debian, Ubuntu, and RHEL/CentOS 7.
RHEL/CentOS 6 and Debian Wheezy (old stable) ship with an older version,
unsurprisingly.

Signed-off-by: Todd Zullinger <tmz at pobox.com>
---
I wrote:

> Jason A. Donenfeld wrote:
>> Seems reasonable to me. Can you resubmit with your `Signed-off-by:`?
> 
> D'oh!
> 
> I meant to check that I had the sign-off and managed to get
> sidetracked before sending.  Signed-off-by: Scatterbrain. ;)

There was supposed to be a proper signoff on that reply.
Scatterbrain was only meant to be a joke.

Third time's a charm, hopefully.  I'll really feel dumb if I
forget it one more time. :/

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 8321ecc..687069f 100644
--- a/Makefile
+++ b/Makefile
@@ -134,7 +134,7 @@ doc-pdf: $(DOC_PDF)
 	a2x -f manpage $<
 
 $(DOC_HTML): %.html : %.txt
-	a2x -f xhtml --stylesheet=cgit-doc.css $<
+	a2x -f xhtml --stylesheet=cgit-doc.css --xsltproc-opts="--param generate.consistent.ids 1" $<
 
 $(DOC_PDF): %.pdf : %.txt
 	a2x -f pdf cgitrc.5.txt
-- 
2.16.2

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
When buying and selling are controlled by legislation, the first
things to be bought and sold are legislators.
    -- P.J. O'Rourke



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] doc: use consistent id's when generating html files
  2018-02-21  1:36     ` tmz
@ 2018-02-21  2:13       ` Jason
  0 siblings, 0 replies; 5+ messages in thread
From: Jason @ 2018-02-21  2:13 UTC (permalink / raw)


This time you forgot the... just kidding.

Applied, thanks.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-02-21  2:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-20 22:10 [PATCH] doc: use consistent id's when generating html files tmz
2018-02-20 22:12 ` Jason
2018-02-20 22:28   ` tmz
2018-02-21  1:36     ` tmz
2018-02-21  2:13       ` Jason

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).