From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: RFE: download patch between arbitrary revisions
Date: Mon, 12 Aug 2013 13:05:18 -0600 [thread overview]
Message-ID: <CAHmME9r7ywi_shy2s0rqhecD1e8toCZMvY+8AXxfpY_GwrU7pQ@mail.gmail.com> (raw)
In-Reply-To: <20130806214035.GA30240@blizzard>
This is a wonderful idea.
The sequence of patches provides a somewhat ridiculous way of
reassembling a git repository from cgit without using the proper http
clone endpoints; I wonder how long it will be before somebody winds up
(ab)using this for this purpose. A max-patches-per-request could
really help to prevent the DoS. On the otherhand, aren't there are a
few other endpoints that can cause similar DoS? If so, maybe we ought
to save max-patches-per-request for another commit that handles other
DoS cases too, and perhaps if we're lucky then be able to consolidate
them into one configuration setting at that point --
max-operations-per-request.
Anyway, go ahead and implement it --
* /patch/ will support id2 param and return format-patch --stdout id1..id2
* /diff/ will be unchanged
* /diff/?raw=1 will spit out the raw output
Sound good?
next prev parent reply other threads:[~2013-08-12 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 1:19 mricon
2013-06-03 18:49 ` john
2013-06-13 21:58 ` cgit
2013-06-13 22:21 ` john
2013-06-16 7:56 ` cgit
2013-06-16 10:11 ` john
2013-06-16 19:18 ` cgit
2013-08-06 19:23 ` mricon
2013-08-06 21:40 ` cgit
2013-08-12 19:05 ` Jason [this message]
2013-08-14 8:56 ` cgit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9r7ywi_shy2s0rqhecD1e8toCZMvY+8AXxfpY_GwrU7pQ@mail.gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).