From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14486 invoked from network); 26 May 2023 14:19:02 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 26 May 2023 14:19:02 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id ba70cd53; Fri, 26 May 2023 14:19:02 +0000 (UTC) Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id d3874f98 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Fri, 26 May 2023 14:19:00 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFD6560BCB for ; Fri, 26 May 2023 14:18:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABA88C4339B for ; Fri, 26 May 2023 14:18:57 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="dT9NwdJL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1685110736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZNiG3ZMZotHKXAeqfDjFggYGYFLL0w4EVv9v+n2RuBs=; b=dT9NwdJLJZ4a9ktC/7t6eWfAK1mN4R24re1QWVyYc6XK3TD0f0/tRKSJlychy3gpUgPYRq v68Nl8aZcFTCRvgMGaRmlAbrS5PhnyVRV7Zh7PmOAAf6SkxUcYUZdtF3kZL77OQ6DN3oy3 cPu2LUtxflPjpyqVlMANHK9sskm5qs4= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id c0d73294 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 26 May 2023 14:18:54 +0000 (UTC) Received: by mail-ua1-f42.google.com with SMTP id a1e0cc1a2514c-78400319b0eso244162241.2 for ; Fri, 26 May 2023 07:18:54 -0700 (PDT) X-Gm-Message-State: AC+VfDxxqZToGo0vBgKHR7/m/jQ/JQbkjjUOf/TicuDiFaUg8svmNjVR uADu1EsSLNeLARpdt7JvsA8mKFSZvRmGri8PKpg= X-Google-Smtp-Source: ACHHUZ5Pkct2yeE/argXhE7618sObRZnKImS56GS+74b6Llp7VsynZ1CIpmTR70exs3Qgcv4fLe7ovxcLiv5z9ahvmc= X-Received: by 2002:a67:f90a:0:b0:434:4809:5520 with SMTP id t10-20020a67f90a000000b0043448095520mr530396vsq.25.1685110733928; Fri, 26 May 2023 07:18:53 -0700 (PDT) MIME-Version: 1.0 References: <20230526110646.60621-1-list@eworm.de> <20230526160653.7962c827@leda.eworm.net> <20230526161735.57ebdc54@leda.eworm.net> In-Reply-To: <20230526161735.57ebdc54@leda.eworm.net> From: "Jason A. Donenfeld" Date: Fri, 26 May 2023 16:18:42 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] RFC: git: update to v2.41.0-rc2 To: Christian Hesse Cc: cgit@lists.zx2c4.com, Christian Hesse Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" On Fri, May 26, 2023 at 4:17=E2=80=AFPM Christian Hesse wro= te: > > Christian Hesse on Fri, 2023/05/26 16:06: > > > Like string_list_split(), except that string is split in-place: the > > > delimiter characters in string are overwritten with NULs, and the > > > new string_list_items point into string (which therefore must not > > > be modified or freed while the string_list is in use). > > > list->strdup_strings must *not* be set. > > > > So we should be fine with the change, no? > > Ah, the strings are not allocated, but we should run: > > string_list_clear(&list, 0); > > Is it fine then? Right. My understanding is that while the strings themselves are not allocated, the array of string list items still is.