List for cgit developers and users
 help / color / mirror / Atom feed
From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH] tests: use Git's test framework
Date: Thu, 4 Apr 2013 16:24:57 +0200	[thread overview]
Message-ID: <CAHmME9rNLM1tVcs3bcfz=vBVm9kPabfYEuFi9Vddixqpvx4YWQ@mail.gmail.com> (raw)
In-Reply-To: <43a3cf29f2cfe519b86396aaf86288e87f237776.1364825141.git.john@keeping.me.uk>

On Mon, Apr 1, 2013 at 4:09 PM, John Keeping <john at keeping.me.uk> wrote:
> This allows tests to run in parallel as well as letting us use "prove"
> or another TAP harness to run the tests.
>
> Git's test framework requires Git to be fully built before letting any
> tests run, so add a new target to the top-level Makefile which builds
> all of Git instead of just libgit.a and make the "test" target depend on
> that.

I don't think that's a problem. Technically, the tests should be
against the git revision that cgit uses, not the system git.

My only hesitation is whether or not the pretty printing benefits are
worth the added complexity.




  reply	other threads:[~2013-04-04 14:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 14:09 john
2013-04-04 14:24 ` Jason [this message]
2013-04-04 14:34   ` john
2013-04-04 14:32 ` Jason
2013-04-04 16:19   ` mailings
2013-04-07 15:28 ` Jason
2013-04-08 14:28   ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHmME9rNLM1tVcs3bcfz=vBVm9kPabfYEuFi9Vddixqpvx4YWQ@mail.gmail.com' \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).