From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Mon, 15 Apr 2013 16:48:45 +0200
Subject: [PATCH 1/2] t0109: refactor test code into a function
In-Reply-To: <cb27d4b69dce1c7e89702894b049dc647169b17a.1365955662.git.john@keeping.me.uk>
References: <cb27d4b69dce1c7e89702894b049dc647169b17a.1365955662.git.john@keeping.me.uk>
Message-ID: <CAHmME9rSCWtueOX3aRnmaD_MGFqpadwT92UjZ5YMN_J3KL9V4Q@mail.gmail.com>

On Sun, Apr 14, 2013 at 6:07 PM, John Keeping <john at keeping.me.uk> wrote:
> -test_expect_success 'no access to $HOME' '
> +test_no_home_access () {
>         non_existant_path="/path/to/some/place/that/does/not/possibly/exist"
>         while test -d "$non_existant_path"; do
>                 non_existant_path="$non_existant_path/$(date +%N)"
> -       done
> +       done &&
> +       CGIT_CONFIG="$(pwd)/cgitrc" QUERY_STRING="url=$1" \

Superfluous, as strace sets environment variables.


>         strace \
>                 -E HOME="$non_existant_path" \
>                 -E CGIT_CONFIG="$PWD/cgitrc" \
>                 -E QUERY_STRING="url=foo/commit" \

In fact, it still picks up this old one.

>                 -e access -f -o strace.out cgit &&
>         test_must_fail grep "$non_existant_path" strace.out
> +}
> +
> +test_expect_success 'no access to $HOME' '
> +       test_no_home_access ""
>  '
>

I refactored this commit and 2/2 here:

http://git.zx2c4.com/cgit/commit/?h=wip&id=a814ede7838c5d2be8d0e926e2dfe4a4c66d7dcc