List for cgit developers and users
 help / color / mirror / Atom feed
From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH] filter: basic write hooking infrastructure
Date: Mon, 13 Jan 2014 00:10:29 +0100	[thread overview]
Message-ID: <CAHmME9rTJDDf8y=CXBLGrbrC8iyrc-L+J6byuHXGxZfW=U8tiw@mail.gmail.com> (raw)
In-Reply-To: <20140112225223.GW7608@serenity.lan>

On Sun, Jan 12, 2014 at 11:52 PM, John Keeping <john at keeping.me.uk> wrote:
> Clever.  I've been looking at hooking in at a higher level before html.c
> escapes the output.  But I think the approach taken with source_filter
> may be a better way of getting the raw output to the filter.
>
> I can't help thinking it would be easier to just replace html_raw here
> though.  All our writes go through there anyway and we don't need to
> worry about writing to other file descriptors.

That was my original idea too. But then I saw that often times we
_don't_ actually use html_raw. Sometimes we printf directly, and other
times, git itself writes data. I don't want to maintain a patchset
against git, so it seemed like the lower level was the only way to go.


      reply	other threads:[~2014-01-12 23:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-12 21:58 Jason
2014-01-12 22:31 ` [PATCH v2] " Jason
2014-01-12 22:52 ` [PATCH] " john
2014-01-12 23:10   ` Jason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHmME9rTJDDf8y=CXBLGrbrC8iyrc-L+J6byuHXGxZfW=U8tiw@mail.gmail.com' \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).