From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH] Use strbuf for reading configuration files
Date: Tue, 4 Jun 2013 19:35:19 +0200 [thread overview]
Message-ID: <CAHmME9rUy4BAdrD0rwfPFYTQXOCDYZuhPLhs7BEPdW17hUG9Gg@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9r+1cT7hkGbHOL0qNsF0GHN73FBmC0YkW0n+8EhND2XzQ@mail.gmail.com>
It looks like we can also borrow routines directly from git, off of which
it appears config.c was initial based:
http://git.zx2c4.com/git/tree/config.c
In fact, what about reworking our config in general to use git's system?
This would involve supporting both our:
repo.blah = val
syntax as well as
[repo]
blah = val
which might be a little bit nice.
http://git.zx2c4.com/git/tree/config.c#n898
git_config_from_file might be a possibility.
We'd get nice escaping too.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20130604/77e78961/attachment.html>
next prev parent reply other threads:[~2013-06-04 17:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 20:21 configfile.c:63:14: warning: array subscript is above array [-Warray-bounds] koverstreet
2013-06-04 10:34 ` Jason
2013-06-04 13:57 ` cgit
2013-06-04 14:47 ` [PATCH] Use strbuf for reading configuration files cgit
2013-06-04 15:43 ` cgit
2013-06-04 17:29 ` Jason
2013-06-04 17:35 ` Jason [this message]
2013-06-04 17:39 ` cgit
2013-06-04 17:40 ` Jason
2013-06-04 17:49 ` Jason
2013-06-04 18:23 ` john
2013-06-05 11:20 ` cgit
2013-06-05 11:17 ` [PATCH v2] " cgit
2013-06-13 21:25 ` cgit
2013-08-02 17:13 ` cgit
2013-08-02 18:14 ` Jason
2013-08-12 18:52 ` Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9rUy4BAdrD0rwfPFYTQXOCDYZuhPLhs7BEPdW17hUG9Gg@mail.gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).