[PATCH] html.c: die when write fails

[PATCH] html.c: die when write fails

[john]

If we fail to write HTML output once, there's no point carrying on so
just write a failure message once and die.  By using Git's die_errno
function we also let the user know in what way the write failed.

Signed-off-by: John Keeping <john at keeping.me.uk>
---
 html.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/html.c b/html.c
index f7772dc..03277db 100644
--- a/html.c
+++ b/html.c
@@ -78,7 +78,7 @@ char *fmtalloc(const char *format, ...)
 void html_raw(const char *data, size_t size)
 {
 	if (write(htmlfd, data, size) != size)
-		fprintf(stderr, "[html.c] html output truncated.\n");
+		die_errno("write error on html output");
 }
 
 void html(const char *txt)
-- 
1.8.3.rc2.285.gfc18c2c

[PATCH] html.c: die when write fails

[Jason]

It seems reasonable to die like this. However, if we're going to start
using git's die_errno, I'd also like to use that in other places
instead of die().

[PATCH] html.c: die when write fails

[john]

On Sat, May 18, 2013 at 05:05:21PM +0200, Jason A. Donenfeld wrote:
> It seems reasonable to die like this. However, if we're going to start
> using git's die_errno, I'd also like to use that in other places
> instead of die().

Yeah, there are probably a lot of places that would be helped by this.
This was just the one I noticed when I mis-clicked and then clicked
again aborting the first request, which caused a spew of "html output
truncated" messages as CGit carried on generating the page.