From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 6353 invoked from network); 12 Jan 2023 00:35:02 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 12 Jan 2023 00:35:02 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 01c84000; Thu, 12 Jan 2023 00:35:02 +0000 (UTC) Return-Path: Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 0a579bdf (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Thu, 12 Jan 2023 00:35:00 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B20FDB81D7E for ; Thu, 12 Jan 2023 00:34:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31F01C433F0 for ; Thu, 12 Jan 2023 00:34:58 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="D0N5L2Ka" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1673483695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uPB2GO2EMGgwqkyNQCnhTeMc1Iwtx77cunSityemDjM=; b=D0N5L2KaTLRBLLBw3MuwYECZTEV7Cubl8Qimv6tMU9HYH3XkQfYL85jcXb3/JXVWpwmLZl 2DIjCk7GNb94GF68HluDP0Z0/PyWA9MKfowiVbMSEEOuShaxXRxrZxnRIYUGtYDwMXO7Mp r3eUIgO3RiSXchOzINRd7uHgPL89L+0= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id c3d949f4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Thu, 12 Jan 2023 00:34:55 +0000 (UTC) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-4b718cab0e4so218177497b3.9 for ; Wed, 11 Jan 2023 16:34:55 -0800 (PST) X-Gm-Message-State: AFqh2kqqpYS4S6ll8s+OUiDyfYPQrOEAW87CZdfYsFjIELc/nvgcWfC6 USQ2hgyVn6otQZLr73PTWkQWtQun6GoAD1zoNu0= X-Google-Smtp-Source: AMrXdXuZVyKTWZtOdmWUQIx1Iru3io7Ibi4OPitvsJ1Xlr6M7yvTazL3OvwSns7MYZJUZGpp8K+taP3DtVBzVe3PVtA= X-Received: by 2002:a81:494a:0:b0:3dd:bcc2:e359 with SMTP id w71-20020a81494a000000b003ddbcc2e359mr2415411ywa.341.1673483694794; Wed, 11 Jan 2023 16:34:54 -0800 (PST) MIME-Version: 1.0 References: <20230101214103.1E52F19A2@badger.kodafritt.se> <20230105225343.0264A262C@badger.kodafritt.se> <20230112013305.0b5ccab36a3a81330f91f371@kodafritt.se> In-Reply-To: <20230112013305.0b5ccab36a3a81330f91f371@kodafritt.se> From: "Jason A. Donenfeld" Date: Thu, 12 Jan 2023 01:34:43 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RESEND v2] css: Support for dark mode To: =?UTF-8?Q?Samuel_Lid=C3=A9n_Borell?= Cc: cgit@lists.zx2c4.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" On Thu, Jan 12, 2023 at 1:33 AM Samuel Lid=C3=A9n Borell wrote: > > Oops. I made a last minute change of the themes, and that broke things. L= ooks like some theme combinations don't work well. > > I will send an updated patch with a working theme combo + a comment about= this. > > It could also be solved by also wrapping the light theme in a media query= , but then older browsers will not show the highlighting. Heh, we just sent emails at the same time. See the one I just sent you -- it has a diff for your consideration. Jason