From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH 1/4] snapshots: Don't allow sneaked in snapshots requests
Date: Sun, 28 Oct 2012 14:40:35 -0600 [thread overview]
Message-ID: <CAHmME9rWyqU61Jy+ep+BK2EsO+ZvPDsxqBnU3CHA0QJRvSfZzw@mail.gmail.com> (raw)
In-Reply-To: <1351455531-12208-1-git-send-email-sebastian@breakpoint.cc>
On Sun, Oct 28, 2012 at 2:18 PM, Sebastian Andrzej Siewior
<sebastian at breakpoint.cc> wrote:
> If the snapshots are not enabled then the frontend won't show a link to it.
> The skilled user however may construct the URL on his own and the frontend
> will obey the request.
> This patch adds a check for this case so the requst won't be served.
What's the purpose of this? I kind of like just having tar.xz and zip
enabled on mine, and then for folks who need tar.gz (like for bsd pkg
managers), they can have the other link. That way UI clutter is
minimized while the functionality stays in tact.
"Disabling snapshots" as a security "feature" isn't really so valid either.
next parent reply other threads:[~2012-10-28 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1351455531-12208-1-git-send-email-sebastian@breakpoint.cc>
2012-10-28 20:40 ` Jason [this message]
2012-10-29 0:33 ` nobody
2014-01-18 20:24 my out-of-tree patches for cgit sebastian
2014-01-18 20:24 ` [PATCH 1/4] snapshots: Don't allow sneaked in snapshots requests sebastian
2014-02-01 14:54 ` sebastian
2014-02-02 14:49 ` cgit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9rWyqU61Jy+ep+BK2EsO+ZvPDsxqBnU3CHA0QJRvSfZzw@mail.gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).