From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Fri, 1 Feb 2013 12:58:25 +0100
Subject: [PATCH] Return "404 Not found" if a repo doesn't exist (any more).
In-Reply-To: <87sj7pa0t2.fsf@topper.koldfront.dk>
References: <87sj7pa0t2.fsf@topper.koldfront.dk>
Message-ID: <CAHmME9raNC542b1kWy3njdtKotT2aGZSgz8Lh=YH80A3KFa5xQ@mail.gmail.com>

On Sat, Dec 1, 2012 at 11:02 PM, Adam Sj?gren <asjo at koldfront.dk> wrote:
> @@ -247,6 +247,17 @@ void cgit_print_repolist()
>         if (ctx.cfg.enable_index_links)
>                 columns++;
>
> +       for (i=0; i<cgit_repolist.count; i++) {
> +               if (!(is_match(&cgit_repolist.repos[i]) && is_in_url(&cgit_repolist.repos[i])))
> +                       continue;
> +               hits++;
> +        }
> +
> +       if (!hits) {
> +                ctx.page.status = 404;
> +                ctx.page.statusmsg = "Not found";
> +        }
> +

I like the idea of this, but I hate to duplicate the loop logic like that.

But in fact we do need to know whether there are any hits before
sending headers.

Tricky. I'll see if I can refactor things to be a bit nicer.