List for cgit developers and users
 help / color / mirror / Atom feed
From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH] add git config parsing during scan-path
Date: Tue, 9 Oct 2012 13:33:15 +0200	[thread overview]
Message-ID: <CAHmME9rbG6v91wgpHBCOLqJKQwTPuNOXtpkbKhs-soJiDY7K5A@mail.gmail.com> (raw)
In-Reply-To: <1349780174-3274-1-git-send-email-jamie.couture@gmail.com>

On Tue, Oct 9, 2012 at 12:56 PM, Jamie Couture <jamie.couture at gmail.com> wrote:
> +       else if (!prefixcmp(key, "cgit.")) {
> +               config_fn(repo, key + 5, value);
> +       }
> +

This check isn't sufficient, since if the enable_git_config is not
enabled, but the existing gitweb_section/description settings are
enabled, then enable_git_config becomes implicitly enabled.

But maybe this points to a larger issue: too many settings here. It
seems like we might be best with a single enable_git_config setting
that takes into account known gitweb.* as well as merging cgit.*.

OTOH, maybe it's better to just add a defbranch key to the gitweb
namespace. There already exists category, owner, and description. If
we add defbranch, what other features are folks actually going to want
to be configurable within gitconfig?

If there are additional keys that people want, then I'm fine having
the gitweb namespace as well as the cgit namespace, but if this is
actually just in the name of defbranch, there might be a simpler
solution.




  reply	other threads:[~2012-10-09 11:33 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27  1:39 Maintaining My Own Cgit Tree Jason
2012-09-27  4:22 ` william.bell
2012-09-27  9:00   ` Tobias.Bieniek
2012-09-27 15:53   ` webmaster
2012-09-29  0:30 ` [PATCH] Added code to output the age as seconds instead of "0 min." lsworkemail112
2012-09-29  5:20   ` Jason
2012-09-29 18:43     ` lsworkemail112
2012-09-29 18:51       ` Jason
2012-09-29 19:14         ` lsworkemail112
2012-09-29 19:15           ` Jason
2012-09-29 19:17             ` lsworkemail112
2012-09-29 19:16           ` lsworkemail112
2012-09-30  5:51       ` mailings
2012-09-30 17:28         ` lsworkemail112
2012-09-30 17:29         ` Jason
2012-09-30 17:40           ` mailings
2012-09-30 21:06           ` lsworkemail112
2012-09-30 21:33             ` Jason
2012-10-01  6:12               ` mailings
2012-10-02  1:46                 ` lsworkemail112
2012-10-02  2:04                   ` Jason
2012-10-02  2:08                     ` lsworkemail112
2012-10-01 13:56       ` webmaster
2012-10-08 16:48 ` [PATCH 1/2] add git config parsing during scan-path jamie.couture
2012-10-08 16:48   ` [PATCH 2/2] update documentation jamie.couture
2012-10-08 21:05     ` 
2012-10-08 21:18     ` 
2012-10-08 16:49 ` [PATCH] repolist pagination changes jamie.couture
2012-10-08 21:39   ` Jason
2012-10-08 17:12 ` [PATCH] add tag target to generate ctags jamie.couture
2012-10-08 21:41   ` Jason
2012-10-09 10:56 ` [PATCH] add git config parsing during scan-path jamie.couture
2012-10-09 11:33   ` Jason [this message]
2012-10-09 11:15 ` Maintaining My Own Cgit Tree mailings
2012-10-09 11:18   ` Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9rbG6v91wgpHBCOLqJKQwTPuNOXtpkbKhs-soJiDY7K5A@mail.gmail.com \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).