From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason at zx2c4.com (Jason A. Donenfeld) Date: Wed, 31 Oct 2012 22:20:51 -0600 Subject: [PATCHv4 2/2] Helper script to interface to gitolite In-Reply-To: <20121101032356.GA29338@sir-slippy> References: <1351709440-29185-1-git-send-email-valentin.haenel@gmx.de> <1351709556-29355-2-git-send-email-valentin.haenel@gmx.de> <20121101030301.GA28025@neptune.phub.net.cable.rogers.com> <20121101032356.GA29338@sir-slippy> Message-ID: 1. If PATH is controlled by an attacker, it's already game over, regardless of this script. 2. Using `which` doesn't make sense, since in a shell script you just call it by the name, and then it searches path. 3. Gitolite is frequently installed just in a home directory, in the case of shared hosting, not globally in /usr or /usr/local. 4. So, the best way is just to call gitolite by typing "gitolite"