From: Jason at zx2c4.com (Jason A. Donenfeld)
Subject: [PATCH 4/6] filter: add fprintf_filter function
Date: Sun, 12 Jan 2014 20:23:02 +0100 [thread overview]
Message-ID: <CAHmME9rdjLVJ_qPdHdehq0bWLQU5dV8zphJoi2jdZHabhYVv0w@mail.gmail.com> (raw)
In-Reply-To: <da4ef1081a0c71675e1750202b6b39aabf4d0ce8.1389546691.git.john@keeping.me.uk>
What's the purpose of this? Why not just keep the original string that
was passed to about-filter=... in the cmd variable as we have now? The
thing that's variable from filter to filter is argv, the type (commit,
about, etc), and the mechanism (lua, stdout, etc). But the variable
aspects don't require changing ->cmd do they?
next prev parent reply other threads:[~2014-01-12 19:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 17:13 [RFC/PATCH 0/6] Preparation for more filter types john
2014-01-12 17:13 ` [PATCH 1/6] html: remove redundant htmlfd variable john
2014-01-12 19:11 ` Jason
2014-01-12 17:13 ` [PATCH 2/6] ui-snapshot: set unused cgit_filter fields to zero john
2014-01-12 17:13 ` [PATCH 3/6] filter: pass extra arguments via cgit_open_filter john
2014-01-12 19:20 ` Jason
2014-01-12 17:13 ` [PATCH 4/6] filter: add fprintf_filter function john
2014-01-12 19:23 ` Jason [this message]
2014-01-12 19:35 ` john
2014-01-12 19:40 ` Jason
2014-01-12 17:13 ` [PATCH 5/6] filter: add interface layer john
2014-01-12 17:13 ` [PATCH 6/6] filter: introduce "filter type" prefix john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9rdjLVJ_qPdHdehq0bWLQU5dV8zphJoi2jdZHabhYVv0w@mail.gmail.com \
--to=cgit@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).