From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason at zx2c4.com (Jason A. Donenfeld)
Date: Wed, 8 Jan 2014 17:00:50 +0100
Subject: [PATCH 1/1] enable cgit to show gravatar for author, committer
 and tagger
In-Reply-To: <1389194613-8660-1-git-send-email-mail@eworm.de>
References: <CAHmME9pbkGfZbvCVB4rmiqMMDS0imF40xA56V7vvjZZM6=xb5w@mail.gmail.com>
 <1389194613-8660-1-git-send-email-mail@eworm.de>
Message-ID: <CAHmME9rjttQv3y0=W8iTM1ArY9o=tNAFyNOBh8EV2y=KuXWbig@mail.gmail.com>

Sorry for the extended nitpicks....

On Wed, Jan 8, 2014 at 4:23 PM, Christian Hesse <mail at eworm.de> wrote:
> +char *cgit_get_gravatar(const char *email)
> +{
> +
> +       /* duplicate to lower and skip brackets! */
> +       lower = strdup(email + 1);
> +       lower[strlen(lower) - 1] = '\0';


Can email ever be passed in with no length at all? Or without
brackets? It's not immediately clear to me from looking briefly at
parse_user in parsing.c.