* adopting kernel.org's css modifications?
@ 2014-02-20 19:23 Jason
2014-02-20 20:27 ` cgit
2014-02-22 16:12 ` mricon
0 siblings, 2 replies; 4+ messages in thread
From: Jason @ 2014-02-20 19:23 UTC (permalink / raw)
Looks like kernel.org makes some changes. Do we want to adopt any of
these? Some of them are pretty, like the even/odd background. Others
I'm not sure what they do...
--- cgit.css 2014-02-20 20:07:39.000000000 +0100
+++ cgit-korg.css 2013-02-28 20:16:48.000000000 +0100
@@ -59,6 +59,7 @@
color: #777;
border-top: solid 1px #ccc;
padding-left: 10px;
+ vertical-align: top;
}
div#cgit table.tabs {
@@ -124,6 +125,14 @@
background: white;
}
+div#cgit table.list tr:nth-child(odd) {
+ background: white;
+}
+
+div#cgit table.list tr:nth-child(even) {
+ background: #f6f6f6;
+}
+
div#cgit table.list tr.logheader {
background: #eee;
}
@@ -132,6 +141,9 @@
background: #eee;
}
+div#cgit table.list tr.nohover {
+ background: white;
+}
div#cgit table.list tr.nohover:hover {
background: white;
}
@@ -291,15 +303,13 @@
padding: 0; margin: 0;
}
-div#cgit table.blob td.linenumbers a,
-div#cgit table.ssdiff td.lineno a {
+div#cgit table.blob a.no, div#cgit table.ssdiff a.no {
color: gray;
text-align: right;
text-decoration: none;
}
-div#cgit table.blob td.linenumbers a:hover,
-div#cgit table.ssdiff td.lineno a:hover {
+div#cgit table.blob a.no a:hover {
color: black;
}
@@ -540,23 +550,17 @@
padding-left: 1.5em;
}
-div#cgit ul.pager {
- list-style-type: none;
+div#cgit div.pager {
text-align: center;
margin: 1em 0em 0em 0em;
- padding: 0;
}
-div#cgit ul.pager li {
- display: inline-block;
- margin: 0.25em 0.5em;
-}
-
-div#cgit ul.pager a {
+div#cgit div.pager a {
color: #777;
+ margin: 0em 0.5em;
}
-div#cgit ul.pager .current {
+div#cgit div.pager .current {
font-weight: bold;
}
@@ -802,3 +806,17 @@
div#cgit table.ssdiff td.space div {
min-height: 3em;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* adopting kernel.org's css modifications?
2014-02-20 19:23 adopting kernel.org's css modifications? Jason
@ 2014-02-20 20:27 ` cgit
2014-02-21 9:57 ` bluewind
2014-02-22 16:12 ` mricon
1 sibling, 1 reply; 4+ messages in thread
From: cgit @ 2014-02-20 20:27 UTC (permalink / raw)
On Thu, 20 Feb 2014 at 20:23:56, Jason A. Donenfeld wrote:
> Looks like kernel.org makes some changes. Do we want to adopt any of
> these? Some of them are pretty, like the even/odd background. Others
> I'm not sure what they do...
> [...]
On the even/odd background (didn't check the other changes): I think
that one looks good when having a lot of repositories and doesn't look
good when having only a few of them. I also think that it is a bit weird
that the "Clone" row is sometimes highlighted, see e.g. [1]. Anyway, it
is just a default style so I don't care a lot.
[1] https://git.kernel.org/cgit/bluetooth/sbc.git/
^ permalink raw reply [flat|nested] 4+ messages in thread
* adopting kernel.org's css modifications?
2014-02-20 20:27 ` cgit
@ 2014-02-21 9:57 ` bluewind
0 siblings, 0 replies; 4+ messages in thread
From: bluewind @ 2014-02-21 9:57 UTC (permalink / raw)
On 20.02.2014 21:27, Lukas Fleischer wrote:
> On Thu, 20 Feb 2014 at 20:23:56, Jason A. Donenfeld wrote:
>> Looks like kernel.org makes some changes. Do we want to adopt any of
>> these? Some of them are pretty, like the even/odd background. Others
>> I'm not sure what they do...
>> [...]
>
> On the even/odd background (didn't check the other changes): I think
> that one looks good when having a lot of repositories and doesn't look
> good when having only a few of them. I also think that it is a bit weird
> that the "Clone" row is sometimes highlighted
Just override the background colour for <th> like so:
div#cgit table.list tr:nth-child(odd),
div#cgit table.list th {
background: white;
}
Apart from that I'm not sure if striping adds much value given table
lines have a different background on hover already.
I didn't look at the other changes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140221/1d3334c0/attachment.asc>
^ permalink raw reply [flat|nested] 4+ messages in thread
* adopting kernel.org's css modifications?
2014-02-20 19:23 adopting kernel.org's css modifications? Jason
2014-02-20 20:27 ` cgit
@ 2014-02-22 16:12 ` mricon
1 sibling, 0 replies; 4+ messages in thread
From: mricon @ 2014-02-22 16:12 UTC (permalink / raw)
On 20/02/14 02:23 PM, Jason A. Donenfeld wrote:
> Looks like kernel.org makes some changes. Do we want to adopt any of
> these? Some of them are pretty, like the even/odd background. Others
> I'm not sure what they do...
The odd-even was requested by people (Linus, namely) who basically
wanted it to look more like gitweb. I'm not a great fan of it myself and
would leave the default style as-is.
Best,
--
Konstantin Ryabitsev
Senior Systems Administrator
Linux Foundation Collab Projects
Montr?al, Qu?bec
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 713 bytes
Desc: OpenPGP digital signature
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20140222/adc89912/attachment.asc>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-22 16:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-20 19:23 adopting kernel.org's css modifications? Jason
2014-02-20 20:27 ` cgit
2014-02-21 9:57 ` bluewind
2014-02-22 16:12 ` mricon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).