From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_ZEN_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.4 Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) by inbox.vuxu.org (Postfix) with ESMTP id 4A64521362 for ; Thu, 21 Aug 2025 21:47:37 +0200 (CEST) Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 66f168bb; Thu, 21 Aug 2025 19:47:11 +0000 (UTC) Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [2607:f8b0:4864:20::32b]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 99a32718 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Thu, 21 Aug 2025 19:47:10 +0000 (UTC) Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-74381dddc44so665214a34.0 for ; Thu, 21 Aug 2025 12:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cbarcenas.com; s=google; t=1755805629; x=1756410429; darn=lists.zx2c4.com; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=jQvyRJF5gCKrjAOP6Dt9XO6cQeznSj1qzkE0cSqw3JE=; b=ZZVk0IrNz0rHyXlYUYzflrIibHXqQ+Fc4XeRO00evX8nKjK6NLI8aMwwNuZjpq9F7r zdNj5e0R/xRoPMzGqzeEdcu+LnS22VjVb7nU53K+IbuUKSfBki1+A6zS1F5F3Q+rKsoz m9/e6Hxleg+p851FpmW5+iNb93U0PT7xznxr4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755805629; x=1756410429; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jQvyRJF5gCKrjAOP6Dt9XO6cQeznSj1qzkE0cSqw3JE=; b=N2Qgk0lC338SkBRT9RIO5zQzdqStFjn/SYi6xEMgKTuWaXKYJf+Dk1zd/HbK5B87SQ /MwcsAtl8mRHoiJSZdpl93itNAFtUzbuoQUIMR6CiCRk2vyTImoMGL/u5ysiKcFfRf8o uJZqgnE8Ai9MmGQ6hDoyqT1x0jLVGUIHWjtvyarxhoO5qwRzhl2io1HHr/Jcue0CiG3p ppT77flM0DOu06M59qjJFL21SHF4hbsJND352uboFVOqGvr6eZUb3Y2bB1eK1CZnvV7y k6JcY0siNteEeK+r8NJxiLj/XuSm9S1A0pHTlagN4SuoW0ZVQQS/wNwjM8aq9C7K8WjU uzcQ== X-Gm-Message-State: AOJu0YwarZ8Wrkg1wiO7kRwLr7V3DzCvz/GlfXWdw0HfN/wPWQE3/nhd KNpPN0wIHM/jekmLItJfAEG+MucJQcCPFJcgOdYixBYZXALVp9cnd8qMrwa8pKgEuKsmcSSFixu EoQEf5cehuctD5YGN4OUE3zGS3hKAMU498SIrqHrGGfyazHzZSZdtSRg= X-Gm-Gg: ASbGncvz85+xNkdC31jVWLzpWen0H8N24e5jBw3nCsxpgs+EsFHen+I9nMX+bPlj1vA T9vh+nD/poslTu7rmtsN1oL6lduLr0qs91alJNfcrkfMORsFwZG7yioBfgwlEbDWJIL81eESIid /TDM6kSRmHQ2eIm1k1kOPQqMx9UYSyXGxqhOKmeR6ErBuB2ON/kJtQpLN3VB7DI1xrYgYtk0FPJ arM/FOB9bkXNO2BcEhrEJ5G9nqwL5YGusf2MVU= X-Google-Smtp-Source: AGHT+IFzq4LUA31/8X5crs+uxcmCkJBxXKV6fajDFx5UDU+4nxVuUT2/cut3kmJJEPupPBdQDvNE3VRFWz7CAKvmNkQ= X-Received: by 2002:a05:6830:2656:b0:742:6d79:ed03 with SMTP id 46e09a7af769-74500a88ebbmr409885a34.24.1755805629054; Thu, 21 Aug 2025 12:47:09 -0700 (PDT) MIME-Version: 1.0 From: Christian Barcenas Date: Thu, 21 Aug 2025 14:46:33 -0500 X-Gm-Features: Ac12FXyZYXy0xCR3DmDa41VtjVPqHlM369mZQCKHtGQ0IZrMjlhEc_bIWLoVz4Q Message-ID: Subject: [PATCH] ui-shared: don't write if favicon unset To: cgit@lists.zx2c4.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" Since the favicon setting defaults to "/favicon.ico", the user can only unset it with favicon=. However, that would write an empty string as the config value. Previously, such empty string always satisfied the if condition. In this case it is better to omit the entirely. Signed-off-by: Christian Barcenas diff --git a/ui-shared.c b/ui-shared.c index 6fae72d..3c33600 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -832,7 +832,7 @@ void cgit_print_docstart(void) else emit_js_link(NULL, "/cgit.js"); - if (ctx.cfg.favicon) { + if (ctx.cfg.favicon && *ctx.cfg.favicon) { html("\n");