From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefan.naewe at gmail.com (Stefan Naewe) Date: Sat, 21 Mar 2015 16:37:39 +0100 Subject: [PATCH] ui-commit: display commit notes as 'raw' In-Reply-To: <20150321131938.GB1344@serenity> References: <1426869593-10432-1-git-send-email-stefan.naewe@gmail.com> <20150320212950.GA1344@serenity> <20150321131938.GB1344@serenity> Message-ID: On Sat, Mar 21, 2015 at 2:19 PM, John Keeping wrote: > On Sat, Mar 21, 2015 at 02:11:51PM +0100, Stefan Naewe wrote: >> On Fri, Mar 20, 2015 at 10:29 PM, John Keeping wrote: >> > On Fri, Mar 20, 2015 at 05:39:53PM +0100, Stefan Naewe wrote: >> >> When the git function format_display_notes() is called >> >> with a value != 0 as the last argument ('raw') the notes text >> >> gets displayed w/o an additional 'Notes:' header. This seems >> >> to be better suited for our needs since we're already displaying >> >> a similar header. >> > >> > What happens when there are multiple display notes refs? It seems that >> > without "raw", format_note() puts the name of the ref in the header it >> > prints (if it's not the default notes ref). >> That's true for 'git show --notes=...' for example. >> >> But how would you specify the name of the notes ref in cgit ? > > git config --add notes.displayRef ... Thanks. That looks like attached. One without and one with my patch. Maybe we should drop the "Notes" headline that cgit generates, instead ? Stefan -- ---------------------------------------------------------------- python -c "print '73746566616e2e6e6165776540676d61696c2e636f6d'.decode('hex')" -------------- next part -------------- A non-text attachment was scrubbed... Name: shot-cgit-notes-2refs.png Type: image/png Size: 10328 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: shot-cgit-notes-2refs-raw.png Type: image/png Size: 6340 bytes Desc: not available URL: