List for cgit developers and users
 help / color / mirror / Atom feed
From: jean-christophe manciot <actionmystique@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: cgit@lists.zx2c4.com
Subject: Re: Version branches
Date: Wed, 4 Jan 2023 17:52:59 +0100	[thread overview]
Message-ID: <CAKcFC3YDnrzSCRYJgr14A-=hko491gBqNyXD8TsiVEVrUb+G2g@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9pAyhB6HB9Ycpz64_foGVjF7dQGQN_t-2ykHnroJsMaXw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

It's not the same: with the first patch (combined with another
attached patch), when I click on a repo from the first page, I go to
the about page.
Here, I end up on the summary page.

On Wed, Jan 4, 2023 at 4:10 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Those got merged to master, long overdue.



-- 
Jean-Christophe

[-- Attachment #2: 0002-about-link-git2.21.0.patch --]
[-- Type: text/x-patch, Size: 649 bytes --]

---
 ui-tree.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ui-tree.c b/ui-tree.c
index 1c7540a..d577c6b 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -254,6 +254,9 @@ static int ls_item(const struct object_id *oid, struct strbuf *base,
 	if (!S_ISGITLINK(mode))
 		cgit_plain_link("plain", NULL, "button", ctx.qry.head,
 				walk_tree_ctx->curr_rev, fullpath.buf);
+	if (!S_ISDIR(mode))
+		cgit_about_link("about", NULL, "button", ctx.qry.head,
+				walk_tree_ctx->curr_rev, fullpath.buf);
 	if (!S_ISDIR(mode) && ctx.repo->enable_blame)
 		cgit_blame_link("blame", NULL, "button", ctx.qry.head,
 				walk_tree_ctx->curr_rev, fullpath.buf);


  reply	other threads:[~2023-01-04 16:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 14:52 jean-christophe manciot
2023-01-04 15:08 ` jean-christophe manciot
2023-01-05 11:52   ` Christian Hesse
2023-01-05 16:45     ` Todd Zullinger
2023-01-04 15:10 ` Jason A. Donenfeld
2023-01-04 16:52   ` jean-christophe manciot [this message]
2023-01-04 16:57     ` jean-christophe manciot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKcFC3YDnrzSCRYJgr14A-=hko491gBqNyXD8TsiVEVrUb+G2g@mail.gmail.com' \
    --to=actionmystique@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).