List for cgit developers and users
 help / color / Atom feed
* [PULL REQUEST] Make default pages configurable
@ 2019-12-09 18:47 
  2019-12-21  2:22 ` tim.cooper
  0 siblings, 1 reply; 3+ messages in thread
From:  @ 2019-12-09 18:47 UTC (permalink / raw)


I proposed this change a while ago, but it didn't seem to get much
attention. Please tell me if I'm doing something wrong.

It would be nice to be able to configure the default page to use for the
root site and repositories. For example, it might make more sense to
have "about" or "tree" as the default landing page for certain repos,
instead of the default "summary".

This patch introduces the following configuration settings:
- "root-default-page": sets the default page for the root site
  (defaults to "repolist")
- "repo.default-page": sets the default page for individual repos
  (defaults to "summary")
- "default-page": global default value for "repo.default-page"

The following accessory changes were required to make this work:
- the "index" tab link on root pages and the "summary" tab link on repo
  pages now explicitly point to their respective targets instead of
  pointing to the site/repo root
- trying to access the "about" page on a repository without one results
  in being redirected to the "summary" page explicitly

The following changes since commit 8fc0c81bbbed21ee30e8a48b2ab1066a029b7b32:

  git: update to v2.23.0 (2019-10-25 11:40:17 +0200)

are available in the Git repository at:

  https://git.monade.li/cgit

for you to fetch changes up to 1431881898ba6044bfd3ae12cc45fb5fcadf80c7:

  Make default pages configurable (2019-12-09 19:38:14 +0100)

----------------------------------------------------------------
Na?m Favier (1):
      Make default pages configurable

 cgit.c        | 10 ++++++++++
 cgit.h        |  3 +++
 cgitrc.5.txt  | 14 ++++++++++++++
 cmd.c         | 18 +++++++++---------
 ui-repolist.c |  2 +-
 ui-shared.c   | 12 +++++++++---
 ui-shared.h   |  2 ++
 7 files changed, 48 insertions(+), 13 deletions(-)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PULL REQUEST] Make default pages configurable
  2019-12-09 18:47 [PULL REQUEST] Make default pages configurable 
@ 2019-12-21  2:22 ` tim.cooper
  2019-12-21 12:38   ` actionmystique
  0 siblings, 1 reply; 3+ messages in thread
From: tim.cooper @ 2019-12-21  2:22 UTC (permalink / raw)


I would find this feature useful as well.

---
Tim Cooper

On 12/9/19 12:47 PM, fnaim42 at gmail.com (Na?m Favier) wrote:
> I proposed this change a while ago, but it didn't seem to get much
> attention. Please tell me if I'm doing something wrong.
> 
> It would be nice to be able to configure the default page to use for the
> root site and repositories. For example, it might make more sense to
> have "about" or "tree" as the default landing page for certain repos,
> instead of the default "summary".
> 
> This patch introduces the following configuration settings:
> - "root-default-page": sets the default page for the root site
>    (defaults to "repolist")
> - "repo.default-page": sets the default page for individual repos
>    (defaults to "summary")
> - "default-page": global default value for "repo.default-page"
> 
> The following accessory changes were required to make this work:
> - the "index" tab link on root pages and the "summary" tab link on repo
>    pages now explicitly point to their respective targets instead of
>    pointing to the site/repo root
> - trying to access the "about" page on a repository without one results
>    in being redirected to the "summary" page explicitly
> 
> The following changes since commit 8fc0c81bbbed21ee30e8a48b2ab1066a029b7b32:
> 
>    git: update to v2.23.0 (2019-10-25 11:40:17 +0200)
> 
> are available in the Git repository at:
> 
>    https://git.monade.li/cgit
> 
> for you to fetch changes up to 1431881898ba6044bfd3ae12cc45fb5fcadf80c7:
> 
>    Make default pages configurable (2019-12-09 19:38:14 +0100)
> 
> ----------------------------------------------------------------
> Na?m Favier (1):
>        Make default pages configurable
> 
>   cgit.c        | 10 ++++++++++
>   cgit.h        |  3 +++
>   cgitrc.5.txt  | 14 ++++++++++++++
>   cmd.c         | 18 +++++++++---------
>   ui-repolist.c |  2 +-
>   ui-shared.c   | 12 +++++++++---
>   ui-shared.h   |  2 ++
>   7 files changed, 48 insertions(+), 13 deletions(-)
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PULL REQUEST] Make default pages configurable
  2019-12-21  2:22 ` tim.cooper
@ 2019-12-21 12:38   ` actionmystique
  0 siblings, 0 replies; 3+ messages in thread
From: actionmystique @ 2019-12-21 12:38 UTC (permalink / raw)


It is useful indeed, I use it for my public site <https://git.sdxlive.com/>
since it was proposed.
But it appears that making it to the cgit git sources as a commit is a
different story.
Maybe the admin(s) could share the policies which make a patch eligible to
the commit status on the master branch, such as:
- being useful to the community
- having passed some thorough functional tests
- having passed some thorough security tests
- ...
What about adding an official development branch?.

On Sat, Dec 21, 2019 at 3:22 AM Tim Cooper <tim.cooper at layeh.com> wrote:

> I would find this feature useful as well.
>
> ---
> Tim Cooper
>
> On 12/9/19 12:47 PM, fnaim42 at gmail.com (Na?m Favier) wrote:
> > I proposed this change a while ago, but it didn't seem to get much
> > attention. Please tell me if I'm doing something wrong.
> >
> > It would be nice to be able to configure the default page to use for the
> > root site and repositories. For example, it might make more sense to
> > have "about" or "tree" as the default landing page for certain repos,
> > instead of the default "summary".
> >
> > This patch introduces the following configuration settings:
> > - "root-default-page": sets the default page for the root site
> >    (defaults to "repolist")
> > - "repo.default-page": sets the default page for individual repos
> >    (defaults to "summary")
> > - "default-page": global default value for "repo.default-page"
> >
> > The following accessory changes were required to make this work:
> > - the "index" tab link on root pages and the "summary" tab link on repo
> >    pages now explicitly point to their respective targets instead of
> >    pointing to the site/repo root
> > - trying to access the "about" page on a repository without one results
> >    in being redirected to the "summary" page explicitly
> >
> > The following changes since commit
> 8fc0c81bbbed21ee30e8a48b2ab1066a029b7b32:
> >
> >    git: update to v2.23.0 (2019-10-25 11:40:17 +0200)
> >
> > are available in the Git repository at:
> >
> >    https://git.monade.li/cgit
> >
> > for you to fetch changes up to 1431881898ba6044bfd3ae12cc45fb5fcadf80c7:
> >
> >    Make default pages configurable (2019-12-09 19:38:14 +0100)
> >
> > ----------------------------------------------------------------
> > Na?m Favier (1):
> >        Make default pages configurable
> >
> >   cgit.c        | 10 ++++++++++
> >   cgit.h        |  3 +++
> >   cgitrc.5.txt  | 14 ++++++++++++++
> >   cmd.c         | 18 +++++++++---------
> >   ui-repolist.c |  2 +-
> >   ui-shared.c   | 12 +++++++++---
> >   ui-shared.h   |  2 ++
> >   7 files changed, 48 insertions(+), 13 deletions(-)
> >
> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/cgit
>


-- 
Jean-Christophe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20191221/00f667d8/attachment.html>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 18:47 [PULL REQUEST] Make default pages configurable 
2019-12-21  2:22 ` tim.cooper
2019-12-21 12:38   ` actionmystique

List for cgit developers and users

Archives are clonable: git clone --mirror http://inbox.vuxu.org/cgit

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.cgit


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git