List for cgit developers and users
 help / color / mirror / Atom feed
* [PATCH] Display e-mail when hovering over committer name in print_branch
@ 2013-02-07  6:06 chris
  2013-02-07  6:09 ` chris
  0 siblings, 1 reply; 2+ messages in thread
From: chris @ 2013-02-07  6:06 UTC (permalink / raw)


I think this would be nice from a UX perspective. Warning: untested
(don't want to use this on my cgit repos as perhaps they are being
looked at in the other thread, but it compiles okay).

Chris


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] Display e-mail when hovering over committer name in print_branch
  2013-02-07  6:06 [PATCH] Display e-mail when hovering over committer name in print_branch chris
@ 2013-02-07  6:09 ` chris
  0 siblings, 0 replies; 2+ messages in thread
From: chris @ 2013-02-07  6:09 UTC (permalink / raw)


From 063a8139b18eac7dba52beb0030b1cfb42712e9c Mon Sep 17 00:00:00 2001
From: Chris Down <chris at chrisdown.name>
Date: Thu, 7 Feb 2013 13:53:27 +0800
Subject: [PATCH] Display e-mail when hovering over committer name in
print_branch

---
 ui-refs.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/ui-refs.c b/ui-refs.c
index caddfbc..242551f 100644
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -78,7 +78,15 @@ static int print_branch(struct refinfo *ref)
    if (ref->object->type == OBJ_COMMIT) {
        cgit_commit_link(info->subject, NULL, NULL, name, NULL, NULL, 0);
        html("</td><td>");
-       html_txt(info->author);
+       if (!ctx.cfg.noplainemail) {
+           html("<span alt='");
+           html_txt(info->committer_email);
+           html("'>");
+           html_txt(info->author);
+           html("</span>");
+       } else {
+           html_txt(info->author);
+       }
        html("</td><td colspan='2'>");
        cgit_print_age(info->commit->date, -1, NULL);
    } else {
--
1.8.1.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-07  6:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-07  6:06 [PATCH] Display e-mail when hovering over committer name in print_branch chris
2013-02-07  6:09 ` chris

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).