CGit Log Links do not have the object id parameter

CGit Log Links do not have the object id parameter

[jlwooster]

The "id" parameter is not added to the "log" links.

For example if you open this commit view
http://git.zx2c4.com/cgit/commit/?id=52c926cadbff5fd0aaf00ebd79619112aba46182and
look at the log link from that page, you'll notice the id parameter is
not retained.

From a quick glance at the source code it looks like the object id should
be kept when generating log links.
Is this a bug?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20130617/cc240ca1/attachment.html>

CGit Log Links do not have the object id parameter

[cgit]

On Mon, Jun 17, 2013 at 12:01:49PM -0500, Jason wrote:
> The "id" parameter is not added to the "log" links.
> 
> For example if you open this commit view http://git.zx2c4.com/cgit/commit/?id=
> 52c926cadbff5fd0aaf00ebd79619112aba46182 and look at the log link from that
> page, you'll notice the id parameter is not retained.
> 
> From a quick glance at the source code it looks like the object id should be
> kept when generating log links.
> Is this a bug?

No, I think that this is intentional. We skip the revision parameter in
the cgit_log_link() invocation in cgit_print_pageheader().

The "log" links allows for getting back to the long list of current
commits with one click. I am not sure whether there are a lot of use
cases for getting a list of commits, starting from the one that is
currently selected.

> _______________________________________________
> CGit mailing list
> CGit at lists.zx2c4.com
> http://lists.zx2c4.com/mailman/listinfo/cgit

CGit Log Links do not have the object id parameter

[jlwooster]

The use case is actually to review the log for a tag, such as if you are on
the page for a tag like http://git.zx2c4.com/cgit/tag/?id=v0.9.0.1.
A link to the log for that tag would be useful (manually entering the
object http://git.zx2c4.com/cgit/log/?id=v0.9.0.1 appears to work).


On Mon, Jun 17, 2013 at 2:07 PM, Lukas Fleischer <cgit at cryptocrack.de>wrote:

> On Mon, Jun 17, 2013 at 12:01:49PM -0500, Jason wrote:
> > The "id" parameter is not added to the "log" links.
> >
> > For example if you open this commit view
> http://git.zx2c4.com/cgit/commit/?id=
> > 52c926cadbff5fd0aaf00ebd79619112aba46182 and look at the log link from
> that
> > page, you'll notice the id parameter is not retained.
> >
> > From a quick glance at the source code it looks like the object id
> should be
> > kept when generating log links.
> > Is this a bug?
>
> No, I think that this is intentional. We skip the revision parameter in
> the cgit_log_link() invocation in cgit_print_pageheader().
>
> The "log" links allows for getting back to the long list of current
> commits with one click. I am not sure whether there are a lot of use
> cases for getting a list of commits, starting from the one that is
> currently selected.
>
> > _______________________________________________
> > CGit mailing list
> > CGit at lists.zx2c4.com
> > http://lists.zx2c4.com/mailman/listinfo/cgit
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20130627/050e2035/attachment.html>