List for cgit developers and users
 help / color / mirror / Atom feed
From: mlhess at umich.edu (Michael Hess)
Subject: Remove a few loops in cgit for a large number of repos.
Date: Thu, 10 Oct 2013 10:44:55 -0400	[thread overview]
Message-ID: <CANNt_rZLNzB_9KkLa_G1vnC0pU-1LE_v7LtA961Rvxer4YM+JA@mail.gmail.com> (raw)

Hi Everyone,


I am looking into using cgit for Drupal.org's repos, and wondering if we
could remove code like this:
http://git.zx2c4.com/cgit/tree/shared.c#n79


We have almost 10,000 repos and are worried about the load from loops, and
building the index it loops over. All of the repos are under a directory
(in 2 different sub directories), so I was hoping we could just validate
the directory path (making sure someone is not trying to do a ../../,etc)
and allow it?

Could that be done?  Please let me know your thoughts.

Thanks
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20131010/06a3d09d/attachment.html>


             reply	other threads:[~2013-10-10 14:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10 14:44 mlhess [this message]
2013-10-10 15:48 ` john
2013-10-10 17:24   ` mlhess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANNt_rZLNzB_9KkLa_G1vnC0pU-1LE_v7LtA961Rvxer4YM+JA@mail.gmail.com \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).