List for cgit developers and users
 help / color / mirror / Atom feed
From: whydoubt at gmail.com (Jeffrey Smith)
Subject: Blame
Date: Wed, 19 Apr 2017 19:55:44 -0500	[thread overview]
Message-ID: <CAPX7N=7f_bsENH84RB4=Q6aM48Ng5REZPbTBXnjzNvXY0n7V0w@mail.gmail.com> (raw)

I have long considered working on blame functionality for cgit, but
recently decided to pursue it. From looking at the history of this list, it
appears that it was last brought up August 2015. The proposal as I
understand it was to spawn off a call to the git command. I do not care for
that solution, but there are still two remaining options that I see.

Option 1: take git's builtin/blame.c, pare it down to the essentials, and
build ui-blame.c around that.
Option 2: work with git upstream to pull portions of builtin/blame.c into
libgit.a, rework builtin/blame.c to use that, and build ui-blame.c to use
that as well.

Having looked at builtin/blame.c for a bit, I think option 2 would be quite
difficult to do cleanly. While option 1 is not ideal, I think it is the
most reasonable. However, I wanted to get some feedback before I went to
the effort only to be told, "only option 2 will do".

 -- Regards,
 -- Jeff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20170419/4973c131/attachment.html>


             reply	other threads:[~2017-04-20  0:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20  0:55 whydoubt [this message]
2017-04-20  0:59 ` Blame Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPX7N=7f_bsENH84RB4=Q6aM48Ng5REZPbTBXnjzNvXY0n7V0w@mail.gmail.com' \
    --to=cgit@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).