From mboxrd@z Thu Jan 1 00:00:00 1970 From: andy at warmcat.com (Andy Green) Date: Tue, 12 Jun 2018 17:27:09 +0800 Subject: Rendering of README.md inline with inner tree view dirs In-Reply-To: <20180612092437.GK1922@john.keeping.me.uk> References: <20180611093152.4821159f@leda> <20180611095343.2865c71d@leda> <20180611153858.GJ1922@john.keeping.me.uk> <20180612103525.442496aa@leda> <20180612092437.GK1922@john.keeping.me.uk> Message-ID: On June 12, 2018 5:24:37 PM GMT+08:00, John Keeping wrote: >On Tue, Jun 12, 2018 at 10:35:25AM +0200, Christian Hesse wrote: >> Andy Green on Tue, 2018/06/12 13:53: >> > 5) I get some gcc 8.1 warnings, I made a couple of patches to get >around >> > them. In a couple of places, the code seemed legit really. >> >> I do see these on Arch as well. :) >> Did not find the time to address them. >> >> > [inline patches] >> > >> > I should include these or the slightly dubious warnings are just >> > regarded as an annoyance? >> >> Definitely to be addressed. I pushed your changes here: >> >> https://git.zx2c4.com/cgit/commit/?h=ch/gcc-8&id=e7ac824f >> >> Builds without warnings and tests are happy, but I did not yet take a >> detailed look. > >We'll need those posted as proper patches with a sign-off though. It >will also be easier to review them that way. No worries I'll send a series with everything including your rebased patches when the remaining things are sorted. I was checking if anyone cared about the warnings. -Andy > >John