From mboxrd@z Thu Jan 1 00:00:00 1970 From: mackyle at gmail.com (Kyle J. McKay) Date: Mon, 12 Aug 2013 12:18:14 -0700 Subject: [PATCH] configfile: Use git's internal config system instead. In-Reply-To: References: <1370368728-27214-1-git-send-email-Jason@zx2c4.com> <20130604185202.GA29937@blizzard> Message-ID: On Aug 12, 2013, at 11:35, Jason A. Donenfeld wrote: > On Tue, Jun 4, 2013 at 8:52 PM, Lukas Fleischer > wrote: >> git_config_from_file() does not allow dots (".") inside configuration >> variable names (since they are used to delimit sections from keys). >> If >> we want to use the Git configuration system like this, we have to >> change >> our configuration file format to use sections ("[repo]") instead of >> prefixing each variable ("repo."). > > I had feared this would be the case. I still think it might be > worthwhile to pursue revamping our configuration format to use > git_config_from_file along with all its niceties. This would also put > us somewhat more in line with upstream git and would allow all sorts > of neat things -- for example instead of a per-repo cgitrc, a repo's > bare gitconfig file could be used instead. We already support reading > a few keys out of it, and moving to using git's config format for > everything would allow us to unify all of this. Also, starting with the 1.8.4 release (currently at 1.8.4-rc2), it's possible to do config_from_blob which may also make some of this easier.