From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 8651 invoked from network); 29 Dec 2020 18:22:25 -0000
Received: from krantz.zx2c4.com (192.95.5.69)
  by inbox.vuxu.org with ESMTPUTF8; 29 Dec 2020 18:22:25 -0000
Received: 
	by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id a5f58db7;
	Tue, 29 Dec 2020 18:12:14 +0000 (UTC)
Return-Path: <uqs@freebsd.org>
Received: from acme.spoerlein.net (acme.spoerlein.net [2a05:fc87:1:5::15])
 by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 13e4c651
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <cgit@lists.zx2c4.com>;
 Tue, 29 Dec 2020 18:12:11 +0000 (UTC)
Received: from localhost (acme.spoerlein.net [IPv6:2a05:fc87:1:5:0:0:0:15])
 by acme.spoerlein.net (8.16.1/8.15.2) with ESMTPS id 0BTIMCbx091664
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 29 Dec 2020 19:22:13 +0100 (CET) (envelope-from uqs@freebsd.org)
Date: Tue, 29 Dec 2020 19:22:11 +0100
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@freebsd.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: cgit@lists.zx2c4.com
Subject: Re: [PATCH] Handle tags outside of refs/tags gracefully.
Message-ID: <X+tz0yd3BMgqxA8U@acme.spoerlein.net>
References: <20201228133550.67945-1-uqs@FreeBSD.org>
 <CAHmME9q339vMyYsPQW1uRTYMiY_MRrEqcy-8V4df5YaqhaiFig@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CAHmME9q339vMyYsPQW1uRTYMiY_MRrEqcy-8V4df5YaqhaiFig@mail.gmail.com>
User-Agent: Mutt/2.0.1 (2020-11-14)
X-BeenThere: cgit@lists.zx2c4.com
X-Mailman-Version: 2.1.30rc1
Precedence: list
List-Id: List for cgit developers and users <cgit.lists.zx2c4.com>
List-Unsubscribe: <https://lists.zx2c4.com/mailman/options/cgit>,
 <mailto:cgit-request@lists.zx2c4.com?subject=unsubscribe>
List-Archive: <http://lists.zx2c4.com/pipermail/cgit/>
List-Post: <mailto:cgit@lists.zx2c4.com>
List-Help: <mailto:cgit-request@lists.zx2c4.com?subject=help>
List-Subscribe: <https://lists.zx2c4.com/mailman/listinfo/cgit>,
 <mailto:cgit-request@lists.zx2c4.com?subject=subscribe>
Errors-To: cgit-bounces@lists.zx2c4.com
Sender: "CGit" <cgit-bounces@lists.zx2c4.com>

On Tue, 2020-12-29 at 12:37:43 +0100, Jason A. Donenfeld wrote:
>This is for the tag UI, though. Aren't tags supposed to live in
>refs/tags/ by definition?
>
>Special casing "refs/" also winds up breaking repositories that
>accidentally push tags literally named 'refs/tags/something'. I've
>seen this happen quite a few times in the real world.

Nothing is really enforced by git, so you can put tags anywhere (and 
suffer the consequences). We decided to have these tags not be pulled by 
default and stashed them under refs/backups/foo so they are not directly 
user visible after a default clone.

If I ask for the tag refs/backups/foo, I expect it to look for that, and 
not for refs/tags/refs/backups/foo. That is what I feel most of the git 
commands do, that need to look up a ref. It was just striking how the 
log handler does handle this just fine (as does the git CLI).

It's unfortunate that there are repos out there with 
refs/tags/refs/tags/bar (what the ... ?). So I guess there's no easy fix 
here then.

Cheers
Uli