From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 24323 invoked from network); 19 Feb 2021 12:22:32 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 19 Feb 2021 12:22:32 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 0a920366; Fri, 19 Feb 2021 12:22:16 +0000 (UTC) Return-Path: Received: from mta01.prd.rdg.aluminati.org (mta01.prd.rdg.aluminati.org [94.76.243.214]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id 61b50d2e (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Fri, 19 Feb 2021 12:22:14 +0000 (UTC) Received: from mta01.prd.rdg.aluminati.org (localhost [127.0.0.1]) by mta.aluminati.local (Postfix) with ESMTP id 8360DBF1CC; Fri, 19 Feb 2021 12:22:14 +0000 (GMT) Received: from localhost (localhost [127.0.0.1]) by mta01.prd.rdg.aluminati.org (Postfix) with ESMTP id 7D5992002D; Fri, 19 Feb 2021 12:22:14 +0000 (GMT) X-Quarantine-ID: X-Virus-Scanned: Debian amavisd-new at mta01.prd.rdg.aluminati.org Received: from mta.aluminati.local ([127.0.0.1]) by localhost (mta01.prd.rdg.aluminati.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TdRGGIERV_1O; Fri, 19 Feb 2021 12:22:13 +0000 (GMT) Received: from john.keeping.me.uk (unknown [81.174.171.191]) by mta01.prd.rdg.aluminati.org (Postfix) with ESMTPSA id 72A015F8C1; Fri, 19 Feb 2021 12:22:08 +0000 (GMT) Date: Fri, 19 Feb 2021 12:22:03 +0000 From: John Keeping To: Kian Kasad Cc: cgit@lists.zx2c4.com Subject: Re: User-configurable log graph option Message-ID: References: <20210218223126.yrgfjni73fi4rvw4@frisbee> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218223126.yrgfjni73fi4rvw4@frisbee> X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" On Thu, Feb 18, 2021 at 02:31:26PM -0800, Kian Kasad wrote: > I'm using cgit on my website and I'm wondering if it's possible to allow > the user (i.e. the person visiting the site) to choose whether or not > the commit graph is displayed on the log page. > > If this isn't currently possible, what do you think about adding such > functionality? Maybe something like how the diff page lets the user > choose between a "unified diff" and "ssdiff". This sounds like a great new feature! I think we still want to allow the administrator to turn the feature on/off but if it is permitted, then it makes sense to allow the end user to choose whether or not they want it enabled. Patches welcome :-)