From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 27267 invoked from network); 7 Oct 2021 09:42:32 -0000 Received: from lists.zx2c4.com (165.227.139.114) by inbox.vuxu.org with ESMTPUTF8; 7 Oct 2021 09:42:32 -0000 Received: by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTP id fc3732e9; Thu, 7 Oct 2021 09:42:15 +0000 (UTC) Return-Path: Received: from mta01.prd.rdg.aluminati.org (mta01.prd.rdg.aluminati.org [94.76.243.214]) by lists.zx2c4.com (ZX2C4 Mail Server) with ESMTPS id f51ab518 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Thu, 7 Oct 2021 09:42:14 +0000 (UTC) Received: from mta01.prd.rdg.aluminati.org (localhost [127.0.0.1]) by mta.aluminati.local (Postfix) with ESMTP id 6F8DEBF0A1; Thu, 7 Oct 2021 10:42:14 +0100 (BST) Received: from localhost (localhost [127.0.0.1]) by mta01.prd.rdg.aluminati.org (Postfix) with ESMTP id 65D832031E; Thu, 7 Oct 2021 10:42:14 +0100 (BST) X-Quarantine-ID: <3DrGIOej-JPd> X-Virus-Scanned: Debian amavisd-new at mta01.prd.rdg.aluminati.org Received: from mta.aluminati.local ([127.0.0.1]) by localhost (mta01.prd.rdg.aluminati.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3DrGIOej-JPd; Thu, 7 Oct 2021 10:42:13 +0100 (BST) Received: from keeping.me.uk (unknown [81.174.171.191]) by svc01-1.prd.rdg.aluminati.org (Postfix) with ESMTPSA id 6E4CF1C0002; Thu, 7 Oct 2021 10:42:10 +0100 (BST) Date: Thu, 7 Oct 2021 10:42:09 +0100 From: John Keeping To: Sergey Bronnikov Cc: cgit@lists.zx2c4.com Subject: Re: [PATCH 0/2] Support of test results Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: cgit@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: List for cgit developers and users List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cgit-bounces@lists.zx2c4.com Sender: "CGit" On Mon, Oct 04, 2021 at 01:22:34PM +0300, Sergey Bronnikov wrote: > From: Sergey Bronnikov > > Git SCM allows to store information in so called notes [1] and cgit > allows to show notes that placed to default reference > ('refs/notes/commits') and attached to certain commits. It is convenient > to add various useful information related to commit in Git notes. > > Often tests results stored for future analysis in different systems (aka > 'test report systems'). But one is the logic places to store test > results is a Git SCM, test report automatically connected to commits and > easily available for everyone. It even can be automated using git-test [2]. This feels very specifc to one use case that isn't particularly general. Have you considered any way to make this more generic for displaying different notes for different purposes? Did you experiment with changing notes.displayRef in gitconfing and using the existing commit filter to display those inline in the commit page? > How-to use: > > $ cat report.tap > 1..2 > ok 1 - test_0.py::test_list_once > ok 2 - test_0.py::test_list_twice > $ GIT_NOTES_REF=refs/notes/testres git notes add -F report.tap 95aa7d200ee10580c472a1156a11c726046b110f > $ git notes add -m 'Tested-by: Sergey Bronnikov ' \ > 2a3a0d1a62de2ae5ab4511c15d82a6a0f2c2a930 > $ GIT_NOTES_REF=refs/notes/testres git show 95aa7d200ee10580c472a1156a11c726046b110f > > commit 95aa7d200ee10580c472a1156a11c726046b110f > Author: Sergey Bronnikov > Date: Tue Dec 22 10:06:10 2020 +0300 > > ... > > Notes (testres): > 1..2 > ok 1 - test_0.py::test_list_once > ok 2 - test_0.py::test_list_twice > > Test report become available in cgit by clicking to href 'tests' for > that commit. > > 1. https://git-scm.com/docs/git-notes > 2. https://github.com/ligurio/git-test > 3. https://github.com/ligurio/testres/wiki/Using-GIT-as-a-storage > > Sergey Bronnikov (2): > ui-commit: add support of test results > ui-commit: add testres filter > > cgit.c | 6 +++ > cgit.h | 4 +- > cgitrc.5.txt | 17 +++++++++ > cmd.c | 8 +++- > filter.c | 6 +++ > filters/testres-example.lua | 21 +++++++++++ > shared.c | 1 + > tests/setup.sh | 2 + > tests/t0105-commit.sh | 7 ++++ > tests/t0111-filter.sh | 8 ++++ > ui-commit.c | 73 ++++++++++++++++++++++++++++++++++++- > ui-commit.h | 1 + > ui-shared.c | 8 +++- > ui-shared.h | 3 ++ > 14 files changed, 161 insertions(+), 4 deletions(-) > create mode 100755 filters/testres-example.lua > > -- > 2.25.1 >